Issue 797042: code review 797042: re2: various tweaks

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 797042: code review 797042: re2: various tweaks (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years ago by rsc

Modified:
15 years ago

Reviewers:

CC:
r, re2-dev_googlegroups.com

Visibility:
Public.

Description

re2: various tweaks add pointers to wrappers in README. drop sed in Makefile to fix exit status. fall back to mutex operations as generic memory barrier. Fixes issue 7. Fixes issue 9. Fixes issue 10.

Patch Set 2 : code review 797042: re2: various tweaks #

Total comments: 1

Patch Set 3 : code review 797042: re2: various tweaks #

Created: 15 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -5 lines)			Patch
M	Makefile	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	README	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	util/atomicops.h	View	1 2	3 chunks	+20 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello r (cc: re2-dev@googlegroups.com), I'd like you to review this change.

15 years ago (2010-03-29 06:54:34 UTC) #1

LGTM http://codereview.appspot.com/797042/diff/2001/3003 File util/atomicops.h (right): http://codereview.appspot.com/797042/diff/2001/3003#newcode36 util/atomicops.h:36: // any mutex implementations has to have s/s// ...

15 years ago (2010-03-29 17:58:27 UTC) #2

rsc

15 years ago (2010-03-29 18:19:33 UTC) #3

*** Submitted as http://code.google.com/p/re2/source/detail?r=aff8c1839c8f ***

re2: various tweaks

add pointers to wrappers in README.
drop sed in Makefile to fix exit status.
fall back to mutex operations as generic memory barrier.

Fixes issue 7.
Fixes issue 9.
Fixes issue 10.

R=r
CC=re2-dev
http://codereview.appspot.com/797042

Expand All Messages | Collapse All Messages