code review 787041: regexp: don't return non-nil *Regexp if there is an error.

regexp: don't return non-nil *Regexp if there is an error.

[r, 2010-03-26 22:43:29]

Hello gri (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[gri, 2010-03-26 22:45:30]

LGTM

On Fri, Mar 26, 2010 at 3:43 PM, <r@golang.org> wrote:

> Reviewers: gri,
>
> Message:
> Hello gri (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change.
>
>
> Description:
> regexp: don't return non-nil *Regexp if there is an error.
>
> Please review this at http://codereview.appspot.com/787041/show
>
> Affected files:
>  M src/pkg/regexp/regexp.go
>  M src/pkg/testing/regexp.go
>
>
> Index: src/pkg/regexp/regexp.go
> ===================================================================
> --- a/src/pkg/regexp/regexp.go
> +++ b/src/pkg/regexp/regexp.go
> @@ -664,6 +664,9 @@
>        regexp.expr = str
>        regexp.inst = new(vector.Vector)
>        error = regexp.doParse()
> +       if error != nil {
> +               regexp = nil
> +       }
>        return
>  }
>
> Index: src/pkg/testing/regexp.go
> ===================================================================
> --- a/src/pkg/testing/regexp.go
> +++ b/src/pkg/testing/regexp.go
> @@ -615,6 +615,9 @@
>        regexp.expr = str
>        regexp.inst = make([]instr, 0, 20)
>        error = regexp.doParse()
> +       if error != nil {
> +               regexp = nil
> +       }
>        return
>  }
>
>
>
>

[r, 2010-03-26 23:18:22]

*** Submitted as http://code.google.com/p/go/source/detail?r=e039086334d8 ***

regexp: don't return non-nil *Regexp if there is an error.

R=gri
CC=golang-dev
http://codereview.appspot.com/787041