code review 762041: bug264 didn't report BUG correctly, caused "fail" from ...

bug264 didn't report BUG correctly, caused "fail" from test/run

[r, 2010-03-25 19:44:02]

Hello rsc, gri (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[gri, 2010-03-25 20:50:13]

LGTM

On Thu, Mar 25, 2010 at 12:44 PM, <r@golang.org> wrote:

> Reviewers: rsc, gri,
>
> Message:
> Hello rsc, gri (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change.
>
>
> Description:
> bug264 didn't report BUG correctly, caused "fail" from test/run
>
> Please review this at http://codereview.appspot.com/762041/show
>
> Affected files:
>  M test/bugs/bug264.go
>  M test/golden.out
>
>
> Index: test/bugs/bug264.go
> ===================================================================
> --- a/test/bugs/bug264.go
> +++ b/test/bugs/bug264.go
> @@ -1,4 +1,4 @@
> -// $G $D/$F.go && $L $F.$A && ./$A.out
> +// $G $D/$F.go && $L $F.$A && ./$A.out || echo BUG
>
>  // Copyright 2010 The Go Authors. All rights reserved.
>  // Use of this source code is governed by a BSD-style
> @@ -38,12 +38,12 @@
>
>  func main() {
>        if fooCount != 1 {
> -               panic("BUG: fooCount != 1")
> +               panic("fooCount != 1")
>        }
>        if barCount != 1 {
> -               panic("BUG: barCount != 1")
> +               panic("barCount != 1")
>        }
>        if balCount != 1 {
> -               panic("BUG: balCount != 1")
> +               panic("balCount != 1")
>        }
>  }
> Index: test/golden.out
> ===================================================================
> --- a/test/golden.out
> +++ b/test/golden.out
> @@ -189,5 +189,6 @@
>  bar
>  bal
>  bal
> -BUG: barCount != 1
> +barCount != 1
>  panic PC=xxx
> +BUG
>
>
>

[r, 2010-03-25 21:27:27]

*** Submitted as http://code.google.com/p/go/source/detail?r=2ab7b406201f ***

bug264 didn't report BUG correctly, caused "fail" from test/run

R=rsc, gri
CC=golang-dev
http://codereview.appspot.com/762041