Issue 755041: code review 755041: Add strconv.Atob, BtoA.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 755041: code review 755041: Add strconv.Atob, BtoA. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 1 month ago by r

Modified:
15 years, 1 month ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

Add strconv.Atob, Btoa. Fixes issue 639

Patch Set 1 #

Patch Set 2 : code review 755041: Add strconv.Atob, BtoA. #

Patch Set 3 : code review 755041: Add strconv.Atob, BtoA. #

Patch Set 4 : code review 755041: Add strconv.Atob, BtoA. #

Patch Set 5 : code review 755041: Add strconv.Atob, Btoa. #

Created: 15 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+94 lines, -17 lines)			Patch
M	src/pkg/flag/flag.go	View		2 chunks	+2 lines, -13 lines	0 comments	Download
M	src/pkg/strconv/Makefile	View		1 chunk	+1 line, -0 lines	0 comments	Download
A	src/pkg/strconv/atob.go	View		1 chunk	+28 lines, -0 lines	0 comments	Download
A	src/pkg/strconv/atob_test.go	View		1 chunk	+56 lines, -0 lines	0 comments	Download
M	src/pkg/xml/read.go	View	2	2 chunks	+7 lines, -4 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Hello golang-dev@googlegroups.com, I'd like you to review this change.

15 years, 1 month ago (2010-03-25 18:41:14 UTC) #1

Hello rsc (cc: golang-dev@googlegroups.com), Please take another look.

15 years, 1 month ago (2010-03-25 18:49:14 UTC) #3

15 years, 1 month ago (2010-03-25 18:50:09 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=065ad1775271 ***

Add strconv.Atob, Btoa.
Fixes issue 639

R=rsc
CC=golang-dev
http://codereview.appspot.com/755041

Expand All Messages | Collapse All Messages