code review 741041: delete all uses of panicln by rewriting them using panic or,

delete all uses of panicln by rewriting them using panic or,
in the tests, println+panic.
gofmt some tests too.

[r, 2010-03-24 22:57:36]

Hello golang-dev@googlegroups.com,

I'd like you to review this change.

[rsc1, 2010-03-24 23:12:32]

LGTM

http://codereview.appspot.com/741041/diff/1/13
File src/pkg/exp/eval/abort.go (right):

http://codereview.appspot.com/741041/diff/1/13#newcode17
src/pkg/exp/eval/abort.go:17: panic("abort:" + err.String())
s/:/: /

http://codereview.appspot.com/741041/diff/1/17
File src/pkg/gob/type.go (left):

http://codereview.appspot.com/741041/diff/1/17#oldcode306
src/pkg/gob/type.go:306: panicln("bootstrap type wrong id:", got.Name(), got,
"not", want)
Lost the line.

http://codereview.appspot.com/741041/diff/1/18
File src/pkg/gob/type_test.go (right):

http://codereview.appspot.com/741041/diff/1/18#newcode31
src/pkg/gob/type_test.go:31: panic("getTypeUnlocked:" + err.String())
s/:/: /

http://codereview.appspot.com/741041/diff/1/23
File src/pkg/reflect/value.go (right):

http://codereview.appspot.com/741041/diff/1/23#newcode506
src/pkg/reflect/value.go:506: panic("type mismatch:" + t1.String() + " != " +
t2.String())
s/:/: /

http://codereview.appspot.com/741041/diff/1/33
File test/cmp1.go (right):

http://codereview.appspot.com/741041/diff/1/33#newcode18
test/cmp1.go:18: } // stack will explain where
move comment up (sorry)

http://codereview.appspot.com/741041/diff/1/33#newcode24
test/cmp1.go:24: } // stack will explain where
move comment up (sorry)

http://codereview.appspot.com/741041/diff/1/41
File test/fixedbugs/bug119.go (right):

http://codereview.appspot.com/741041/diff/1/41#newcode20
test/fixedbugs/bug119.go:20: } // fails (x is incorrect)
move comment up (sorry)

[gri1, 2010-03-24 23:28:30]

LGTM

2010/3/24 <r@golang.org>

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change.
>
>
> Description:
> delete all uses of panicln by rewriting them using panic or,
> in the tests, println+panic.
> gofmt some tests too.
>
> Please review this at http://codereview.appspot.com/741041/show
>
> Affected files:
>  M src/cmd/goyacc/goyacc.go
>  M src/pkg/crypto/block/cfb.go
>  M src/pkg/crypto/block/eax.go
>  M src/pkg/crypto/block/ecb_test.go
>  M src/pkg/crypto/block/ofb.go
>  M src/pkg/crypto/md4/md4.go
>  M src/pkg/crypto/md5/md5.go
>  M src/pkg/crypto/ripemd160/ripemd160.go
>  M src/pkg/crypto/sha1/sha1.go
>  M src/pkg/crypto/sha256/sha256.go
>  M src/pkg/crypto/sha512/sha512.go
>  M src/pkg/exp/eval/abort.go
>  M src/pkg/exp/eval/expr.go
>  M src/pkg/exp/eval/type.go
>  M src/pkg/gob/encode.go
>  M src/pkg/gob/type.go
>  M src/pkg/gob/type_test.go
>  M src/pkg/http/server.go
>  M src/pkg/net/fd.go
>  M src/pkg/reflect/tostring_test.go
>  M src/pkg/reflect/type.go
>  M src/pkg/reflect/value.go
>  M src/pkg/regexp/regexp.go
>  M src/pkg/rpc/client.go
>  M src/pkg/rpc/server_test.go
>  M src/pkg/strconv/fp_test.go
>  M src/pkg/tabwriter/tabwriter_test.go
>  M src/pkg/testing/regexp.go
>  M test/chan/select.go
>  M test/chancap.go
>  M test/closure.go
>  M test/cmp1.go
>  M test/const3.go
>  M test/convert.go
>  M test/ddd.go
>  M test/ddd3.go
>  M test/fixedbugs/bug113.go
>  M test/fixedbugs/bug114.go
>  M test/fixedbugs/bug116.go
>  M test/fixedbugs/bug119.go
>  M test/fixedbugs/bug120.go
>  M test/fixedbugs/bug147.go
>  M test/fixedbugs/bug180.go
>  M test/fixedbugs/bug184.go
>  M test/fixedbugs/bug185.go
>  M test/fixedbugs/bug196.go
>  M test/fixedbugs/bug199.go
>  M test/fixedbugs/bug201.go
>  M test/fixedbugs/bug242.go
>  M test/fixedbugs/bug246.go
>  M test/fixedbugs/bug247.go
>  M test/fixedbugs/bug248.dir/bug2.go
>  M test/fixedbugs/bug254.go
>  M test/garbage/parser.go
>  M test/indirect.go
>  M test/initcomma.go
>  M test/intcvt.go
>  M test/interface/receiver.go
>  M test/ken/chan1.go
>  M test/ken/cplx1.go
>  M test/ken/cplx2.go
>  M test/ken/divconst.go
>  M test/ken/divmod.go
>  M test/ken/embed.go
>  M test/ken/interbasic.go
>  M test/ken/modconst.go
>  M test/ken/range.go
>  M test/ken/slicearray.go
>  M test/ken/sliceslice.go
>  M test/mallocfin.go
>  M test/mallocrand.go
>  M test/mallocrep.go
>  M test/mallocrep1.go
>  M test/method.go
>  M test/method3.go
>  M test/range.go
>  M test/rename.go
>  M test/rename1.go
>  M test/stack.go
>
>
> To unsubscribe from this group, send email to golang-dev+
> unsubscribegooglegroups.com or reply to this email with the words "REMOVE
> ME" as the subject.
>

[r, 2010-03-24 23:46:56]

*** Submitted as http://code.google.com/p/go/source/detail?r=3a1b8703aef9 ***

delete all uses of panicln by rewriting them using panic or,
in the tests, println+panic.
gofmt some tests too.

R=rsc
CC=golang-dev
http://codereview.appspot.com/741041