Issue 705043: code review 705043: pkg/syscall: bring generated files zsyscall_darwin_*.go

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 705043: code review 705043: pkg/syscall: bring generated files zsyscall_darwin_*.go (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 7 months ago by giles

Modified:
15 years, 7 months ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

pkg/syscall: bring generated files zsyscall_darwin_*.go up to date. No functional change, but when these files are regenerated they change, leading to noisy diffs when working in the syscall package.

Patch Set 1 #

Patch Set 2 : code review 705043: pkg/syscall: bring generated files zsyscall_darwin_*.go #

Created: 15 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -12 lines)			Patch
	M	src/pkg/syscall/zsyscall_darwin_386.go	View		2 chunks	+6 lines, -6 lines	0 comments	Download
	M	src/pkg/syscall/zsyscall_darwin_amd64.go	View		2 chunks	+6 lines, -6 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

giles

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change.

15 years, 7 months ago (2010-03-25 03:45:02 UTC) #1

rsc

15 years, 7 months ago (2010-03-25 04:59:24 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=f231d48864a7 ***

syscall: bring generated files zsyscall_darwin_*.go
up to date.

No functional change, but when these files are regenerated
they change, leading to noisy diffs when working in the
syscall package.

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/705043

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages