Issue 6868063: A bit of rectification for learning/tweaks regarding Scheme values (Closed)
|
Created:
11 years, 4 months ago by dak Modified:
11 years, 4 months ago Reviewers:
Trevor Daniels CC:
lilypond-devel_gnu.org Visibility:
Public. |
DescriptionA bit of rectification for learning/tweaks regarding Scheme values
Patch Set 1 #
Total comments: 10
Patch Set 2 : Address Trevor's comments #MessagesTotal messages: 7
Thanks David. Relatively minor quibbles only. https://codereview.appspot.com/6868063/diff/1/Documentation/learning/tweaks.i... File Documentation/learning/tweaks.itely (right): https://codereview.appspot.com/6868063/diff/1/Documentation/learning/tweaks.i... Documentation/learning/tweaks.itely:902: @extending{Calculations in Scheme}. @rextend https://codereview.appspot.com/6868063/diff/1/Documentation/learning/tweaks.i... Documentation/learning/tweaks.itely:925: symbol names, enclosed in parentheses. Drop the comma to make it clear the apostrophe is outside the parentheses or (my preference) use the original sentence construction to preserve the same form as the other entries. https://codereview.appspot.com/6868063/diff/1/Documentation/learning/tweaks.i... Documentation/learning/tweaks.itely:937: @tab Any positive or negative, possibly decimal value , possibly decimal, https://codereview.appspot.com/6868063/diff/1/Documentation/learning/tweaks.i... Documentation/learning/tweaks.itely:952: @tab A constant vector can be written by writing constants I'd prefer the same form as the other entries, just stating what it is, rather than how it might be constructed.
Sign in to reply to this message.
https://codereview.appspot.com/6868063/diff/1/Documentation/learning/tweaks.i... File Documentation/learning/tweaks.itely (right): https://codereview.appspot.com/6868063/diff/1/Documentation/learning/tweaks.i... Documentation/learning/tweaks.itely:902: @extending{Calculations in Scheme}. On 2012/12/04 21:37:12, Trevor Daniels wrote: > @rextend That's a rather major quibble. https://codereview.appspot.com/6868063/diff/1/Documentation/learning/tweaks.i... Documentation/learning/tweaks.itely:925: symbol names, enclosed in parentheses. On 2012/12/04 21:37:12, Trevor Daniels wrote: > Drop the comma to make it clear the apostrophe is > outside the parentheses or (my preference) use the > original sentence construction to preserve the same > form as the other entries. Huh. This started out as "Constant lists ...", and then I moved the constant qualification before the whole table. You are right that the remaining change is somewhat pointless. https://codereview.appspot.com/6868063/diff/1/Documentation/learning/tweaks.i... Documentation/learning/tweaks.itely:937: @tab Any positive or negative, possibly decimal value On 2012/12/04 21:37:12, Trevor Daniels wrote: > , possibly decimal, Definitely not. "direction" is checked by ly:dir?, and ly:dir? _only_ permits -1, 0, 1, and nothing else. "possibly decimal" is definitely wrong. Where an inter/extra-polating value _based_ on directions is permitted, you will find the number? predicate instead. https://codereview.appspot.com/6868063/diff/1/Documentation/learning/tweaks.i... Documentation/learning/tweaks.itely:952: @tab A constant vector can be written by writing constants On 2012/12/04 21:37:12, Trevor Daniels wrote: > I'd prefer the same form as the other entries, > just stating what it is, rather than how it might > be constructed. That is not what was written there before.
Sign in to reply to this message.
https://codereview.appspot.com/6868063/diff/1/Documentation/learning/tweaks.i... File Documentation/learning/tweaks.itely (right): https://codereview.appspot.com/6868063/diff/1/Documentation/learning/tweaks.i... Documentation/learning/tweaks.itely:937: @tab Any positive or negative, possibly decimal value On 2012/12/04 22:27:59, dak wrote: > On 2012/12/04 21:37:12, Trevor Daniels wrote: > > , possibly decimal, > > Definitely not. "direction" is checked by ly:dir?, and ly:dir? _only_ permits > -1, 0, 1, and nothing else. "possibly decimal" is definitely wrong. Where an > inter/extra-polating value _based_ on directions is permitted, you will find the > number? predicate instead. Uh, forget this. I got this mixed up with another change. Will do.
Sign in to reply to this message.
https://codereview.appspot.com/6868063/diff/1/Documentation/learning/tweaks.i... File Documentation/learning/tweaks.itely (right): https://codereview.appspot.com/6868063/diff/1/Documentation/learning/tweaks.i... Documentation/learning/tweaks.itely:952: @tab A constant vector can be written by writing constants On 2012/12/04 22:27:59, dak wrote: > On 2012/12/04 21:37:12, Trevor Daniels wrote: > > I'd prefer the same form as the other entries, > > just stating what it is, rather than how it might > > be constructed. > > That is not what was written there before. No, before, it stated what it was: "A list of three items ...", not "A vector can be written ...".
Sign in to reply to this message.
On 2012/12/04 22:44:22, Trevor Daniels wrote: > https://codereview.appspot.com/6868063/diff/1/Documentation/learning/tweaks.i... > File Documentation/learning/tweaks.itely (right): > > https://codereview.appspot.com/6868063/diff/1/Documentation/learning/tweaks.i... > Documentation/learning/tweaks.itely:952: @tab A constant vector can be written > by writing constants > On 2012/12/04 22:27:59, dak wrote: > > On 2012/12/04 21:37:12, Trevor Daniels wrote: > > > I'd prefer the same form as the other entries, > > > just stating what it is, rather than how it might > > > be constructed. > > > > That is not what was written there before. > No, before, it stated what it was: "A list of three > items ...", not "A vector can be written ...". That's a very specific form of a constant vector of size 3. There is a variety of other ways to enter it. I'll see how I can best address your contention.
Sign in to reply to this message.
Address Trevor's comments
Sign in to reply to this message.
|
