code review 6858079: os: include 0111 in directory file mode on windows

os: include 0111 in directory file mode on windows

Fixes issue 4444.

[brainman, 2012-11-27 05:01:13]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[minux1, 2012-11-27 06:39:53]

http://codereview.appspot.com/6858079/diff/5001/src/pkg/os/os_test.go
File src/pkg/os/os_test.go (right):

http://codereview.appspot.com/6858079/diff/5001/src/pkg/os/os_test.go#newcode...
src/pkg/os/os_test.go:1100: const mode = 0100
test for 0111?
and also change the name of the test.

[brainman, 2012-11-27 06:48:17]

http://codereview.appspot.com/6858079/diff/5001/src/pkg/os/os_test.go
File src/pkg/os/os_test.go (right):

http://codereview.appspot.com/6858079/diff/5001/src/pkg/os/os_test.go#newcode...
src/pkg/os/os_test.go:1100: const mode = 0100
On 2012/11/27 06:39:53, minux wrote:
> test for 0111?

What is wrong with 0100? It does what I need.
I can't think of a situation where directory would not have 0111 set. But I have
been wrong before :-)

> and also change the name of the test.

Sure. Make me an offer.

[minux1, 2012-11-27 06:53:51]

On Tuesday, November 27, 2012, brainman wrote:
>
> http://codereview.appspot.com/**6858079/diff/5001/src/pkg/os/**
>
os_test.go#newcode1100<http://codereview.appspot.com/6858079/diff/5001/src/pkg/os/os_test.go#newcode1100>
> src/pkg/os/os_test.go:1100: const mode = 0100
> On 2012/11/27 06:39:53, minux wrote:
>
>> test for 0111?
>>
>
> What is wrong with 0100? It does what I need.
> I can't think of a situation where directory would not have 0111 set.

because this cl fixes for 0111 in dir. mode so it worth testing.

 and also change the name of the test.
>
> something like TestStatDirModeExec?

[rsc, 2012-11-27 15:07:28]

LGTM
Please do test that all the 0111 bits are set.

[brainman, 2012-11-28 06:02:06]

*** Submitted as http://code.google.com/p/go/source/detail?r=88e4ba173900 ***

os: include 0111 in directory file mode on windows

Fixes issue 4444.

R=golang-dev, minux.ma, rsc
CC=golang-dev
http://codereview.appspot.com/6858079

http://codereview.appspot.com/6858079/diff/5001/src/pkg/os/os_test.go
File src/pkg/os/os_test.go (right):

http://codereview.appspot.com/6858079/diff/5001/src/pkg/os/os_test.go#newcode...
src/pkg/os/os_test.go:1100: const mode = 0100
On 2012/11/27 06:39:53, minux wrote:
> test for 0111?
> and also change the name of the test.

Done.