Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(20)

Issue 6858049: code review 6858049: spec: be clearer about the scope of a package name (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 6 months ago by gri
Modified:
12 years, 6 months ago
Reviewers:
CC:
r, rsc, iant, ken2, dsymonds, golang-dev
Visibility:
Public.

Description

spec: be clearer about the scope of a package name We have the notion of a PackageName, not package identifier. As is, it could construed that imports that rename a package don't have an "imported package identifier" but a local one.

Patch Set 1 #

Patch Set 2 : diff -r 1315abc581ed https://code.google.com/p/go #

Patch Set 3 : diff -r 1315abc581ed https://code.google.com/p/go #

Patch Set 4 : diff -r 1315abc581ed https://code.google.com/p/go #

Patch Set 5 : diff -r 6cee245eb194 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M doc/go_spec.html View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7
gri
Hello r@golang.org, rsc@golang.org, iant@golang.org, ken@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to ...
12 years, 6 months ago (2012-11-21 02:40:17 UTC) #1
dsymonds
Perhaps "The scope of the package name of an imported package ..." (a -> the) ...
12 years, 6 months ago (2012-11-21 03:38:44 UTC) #2
gri
PTAL. http://codereview.appspot.com/6858049/ - gri On Tue, Nov 20, 2012 at 7:38 PM, David Symonds <dsymonds@golang.org> ...
12 years, 6 months ago (2012-11-21 18:15:51 UTC) #3
r
LGTM
12 years, 6 months ago (2012-11-21 19:19:03 UTC) #4
rsc
LGTM
12 years, 6 months ago (2012-11-21 19:29:14 UTC) #5
iant
LGTM
12 years, 6 months ago (2012-11-21 19:46:19 UTC) #6
gri
12 years, 6 months ago (2012-11-21 22:40:57 UTC) #7
*** Submitted as http://code.google.com/p/go/source/detail?r=f2755950769b ***

spec: be clearer about the scope of a package name

We have the notion of a PackageName, not package identifier.
As is, it could construed that imports that rename a package
don't have an "imported package identifier" but a local one.

R=r, rsc, iant, ken, dsymonds
CC=golang-dev
http://codereview.appspot.com/6858049
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b