code review 6856080: libmach, cmd/cc, cmd/cov, cmd/ld, cmd/prof: check mallo...

libmach, cmd/cc, cmd/cov, cmd/ld, cmd/prof: check malloc return value

Update issue 4415.

[minux1, 2012-11-25 20:39:26]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go/

[rsc, 2012-11-26 18:34:29]

LGTM

All the sysfatal can have the { } removed.

https://codereview.appspot.com/6856080/diff/4008/src/cmd/cc/dcl.c
File src/cmd/cc/dcl.c (right):

https://codereview.appspot.com/6856080/diff/4008/src/cmd/cc/dcl.c#newcode1062
src/cmd/cc/dcl.c:1062: print("sigind: out of memory\n");
print("%s: out of memory", argv0);

https://codereview.appspot.com/6856080/diff/4008/src/cmd/cov/main.c
File src/cmd/cov/main.c (right):

https://codereview.appspot.com/6856080/diff/4008/src/cmd/cov/main.c#newcode102
src/cmd/cov/main.c:102: print("ran: out of memory");
sysfatal("out of memory");
sysfatal will insert the argv0: prefix and also exit for you.

https://codereview.appspot.com/6856080/diff/4008/src/cmd/cov/main.c#newcode296
src/cmd/cov/main.c:296: print("breakpoint: out of memory");
sysfatal

https://codereview.appspot.com/6856080/diff/4008/src/cmd/cov/tree.c
File src/cmd/cov/tree.c (right):

https://codereview.appspot.com/6856080/diff/4008/src/cmd/cov/tree.c#newcode56
src/cmd/cov/tree.c:56: print("rwTreeNode: out of memory");
sysfatal

https://codereview.appspot.com/6856080/diff/4008/src/cmd/ld/dwarf.c
File src/cmd/ld/dwarf.c (right):

https://codereview.appspot.com/6856080/diff/4008/src/cmd/ld/dwarf.c#newcode1301
src/cmd/ld/dwarf.c:1301: diag("dwarf: out of memory");
s/dwarf: //
s/inithist: // below

https://codereview.appspot.com/6856080/diff/4008/src/cmd/prof/main.c
File src/cmd/prof/main.c (right):

https://codereview.appspot.com/6856080/diff/4008/src/cmd/prof/main.c#newcode403
src/cmd/prof/main.c:403: fprint(2, "addtohistogram: out of memory");
sysfatal

https://codereview.appspot.com/6856080/diff/4008/src/cmd/prof/main.c#newcode625
src/cmd/prof/main.c:625: fprint(2, "findfunc: out of memory");
sysfatal

https://codereview.appspot.com/6856080/diff/4008/src/cmd/prof/main.c#newcode677
src/cmd/prof/main.c:677: fprint(2, "dumphistogram: out of memory");
sysfatal

https://codereview.appspot.com/6856080/diff/4008/src/cmd/prof/main.c#newcode731
src/cmd/prof/main.c:731: fprint(2, "dumppprof: out of memory");
sysfatal

https://codereview.appspot.com/6856080/diff/4008/src/libmach/executable.c
File src/libmach/executable.c (right):

https://codereview.appspot.com/6856080/diff/4008/src/libmach/executable.c#new...
src/libmach/executable.c:1095: werrstr("out of memory: %r");
"out of memory" is fine. %r is just going to say the same thing

https://codereview.appspot.com/6856080/diff/4008/src/libmach/executable.c#new...
src/libmach/executable.c:1105: werrstr("out of memory: %r");
same.
probably free(cmdbuf) too

https://codereview.appspot.com/6856080/diff/4008/src/libmach/obj.c
File src/libmach/obj.c (right):

https://codereview.appspot.com/6856080/diff/4008/src/libmach/obj.c#newcode297
src/libmach/obj.c:297: fprint(2, "objlookup: out of memory");
sysfatal

[minux1, 2012-11-26 19:05:58]

*** Submitted as http://code.google.com/p/go/source/detail?r=d686006f8945 ***

libmach, cmd/cc, cmd/cov, cmd/ld, cmd/prof: check malloc return value

Update issue 4415.

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/6856080

[dave_cheney.net, 2012-11-26 21:47:13]

Thanks.