Can you submit this? I want a clean 'hg p' before I submit the keep-alive ...
12 years, 5 months ago
(2012-11-24 21:00:54 UTC)
#3
Can you submit this? I want a clean 'hg p' before I submit the keep-alive
tunables and pipelining.
On Friday, November 23, 2012 9:17:00 PM UTC-5, Brad Fitzpatrick wrote:
>
> LGTM
>
> On Fri, Nov 23, 2012 at 9:53 AM, <arctanof...@gmail.com <javascript:>>wrote:
>
>> Reviewers: golang-dev_googlegroups.com,
>>
>> Message:
>> Hello golan...@googlegroups.com <javascript:> (cc:
>> golan...@googlegroups.com <javascript:>),
>>
>> I'd like you to review this change to
>> https://code.google.com/p/go
>>
>>
>> Description:
>> http/transport.go: trivial comment error.
>>
>> Please review this at
http://codereview.appspot.com/**6856078/<http://codereview.appspot.com/6856078/>
>>
>> Affected files:
>> M src/pkg/net/http/transport.go
>>
>>
>> Index: src/pkg/net/http/transport.go
>> ==============================**==============================**=======
>> --- a/src/pkg/net/http/transport.**go
>> +++ b/src/pkg/net/http/transport.**go
>> @@ -71,7 +71,7 @@
>> DisableCompression bool
>>
>> // MaxIdleConnsPerHost, if non-zero, controls the maximum idle
>> - // (keep-alive) to keep to keep per-host. If zero,
>> + // (keep-alive) to keep per-host. If zero,
>> // DefaultMaxIdleConnsPerHost is used.
>> MaxIdleConnsPerHost int
>> }
>>
>>
>>
>
Issue 6856078: code review 6856078: http/transport.go: trivial comment error.
Created 12 years, 5 months ago by cainetighe
Modified 12 years, 5 months ago
Reviewers:
Base URL:
Comments: 0