Issue 6856054: code review 6856054: go/printer: simply ignore filename changes in position ...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6856054: code review 6856054: go/printer: simply ignore filename changes in position ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 8 months ago by gri

Modified:
12 years, 8 months ago

Reviewers:

CC:
r, golang-dev

Visibility:
Public.

Description

go/printer: simply ignore filename changes in position information There's no good reason to make any printer state adjustments simply because the file name in node position information has changed. Eliminate the relevant code.

Patch Set 1 #

Patch Set 2 : diff -r 440de6b98362 https://code.google.com/p/go #

Created: 12 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -15 lines)			Patch
	M	src/pkg/go/printer/printer.go	View		1 chunk	+0 lines, -15 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

gri

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

12 years, 8 months ago (2012-11-16 21:43:24 UTC) #1

gri

12 years, 8 months ago (2012-11-19 21:23:38 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=6d4229bb6307 ***

go/printer: simply ignore filename changes in position information

There's no good reason to make any printer state adjustments
simply because the file name in node position information has
changed. Eliminate the relevant code.

R=r
CC=golang-dev
http://codereview.appspot.com/6856054

Expand All Messages | Collapse All Messages