Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(515)

Issue 6855099: code review 6855099: go/ast: minor cleanup (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 4 months ago by gri
Modified:
11 years, 4 months ago
Reviewers:
CC:
dsymonds, golang-dev
Visibility:
Public.

Description

go/ast: minor cleanup It's better to use IsValid() then checking a (possibly partially set up) position against NoPos directly.

Patch Set 1 #

Patch Set 2 : diff -r 3b146fc28ac6 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/pkg/go/ast/import.go View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
gri
Hello dsymonds (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
11 years, 4 months ago (2012-11-26 23:20:14 UTC) #1
dsymonds
LGTM
11 years, 4 months ago (2012-11-26 23:22:15 UTC) #2
gri
11 years, 4 months ago (2012-11-27 01:18:27 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=616adac0bb59 ***

go/ast: minor cleanup

It's better to use IsValid() then checking a (possibly
partially set up) position against NoPos directly.

R=dsymonds
CC=golang-dev
http://codereview.appspot.com/6855099
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b