Issue 6855096: code review 6855096: go/printer: some internal cleanups

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6855096: code review 6855096: go/printer: some internal cleanups (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 8 months ago by gri

Modified:
12 years, 8 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

go/printer: some internal cleanups Cleanups introduced originally by now abandoned https://codereview.appspot.com/6846078/ . Includes additional test cases for 'if' and 'for' statements. No formatting changes.

Patch Set 1 #

Patch Set 2 : diff -r b26a08dc81f0 https://code.google.com/p/go #

Patch Set 3 : diff -r b26a08dc81f0 https://code.google.com/p/go #

Patch Set 4 : diff -r 026b89723112 https://code.google.com/p/go #

Patch Set 5 : diff -r 026b89723112 https://code.google.com/p/go #

Patch Set 6 : diff -r 026b89723112 https://code.google.com/p/go #

Patch Set 7 : diff -r c2c17abf9eb0 https://code.google.com/p/go #

Created: 12 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+173 lines, -30 lines)			Patch
M	src/pkg/go/printer/nodes.go	View	1 2 3 4 5 6	6 chunks	+33 lines, -26 lines	0 comments	Download
M	src/pkg/go/printer/testdata/statements.golden	View	1 2	2 chunks	+81 lines, -1 line	0 comments	Download
M	src/pkg/go/printer/testdata/statements.input	View	1	2 chunks	+59 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

gri

Hello rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

12 years, 8 months ago (2012-11-26 18:06:49 UTC) #1

gri

12 years, 8 months ago (2012-11-26 21:20:33 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=3fc28eec1b38 ***

go/printer: some internal cleanups

Cleanups introduced originally by now abandoned
https://codereview.appspot.com/6846078/ .

Includes additional test cases for 'if' and 'for'
statements.

No formatting changes.

R=rsc
CC=golang-dev
http://codereview.appspot.com/6855096

Expand All Messages | Collapse All Messages