Issue 6854096: code review 6854096: spec: add () to method calls in examples

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6854096: code review 6854096: spec: add () to method calls in examples (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 6 months ago by rsc

Modified:
12 years, 6 months ago

Reviewers:

CC:
gri, golang-dev

Visibility:
Public.

Description

spec: add () to method calls in examples Since p.M is rejected (must call methods), use p.M(), to keep the examples compiling. Fixes issue 4441.

Patch Set 2 : diff -r b5f58df8efce https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r b5f58df8efce https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 4 : diff -r 1470920a2804 https://go.googlecode.com/hg/ #

Created: 12 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	doc/go_spec.html	View	1 2 3	2 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello gri (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 6 months ago (2012-11-26 16:01:49 UTC) #1

gri

LGTM https://codereview.appspot.com/6854096/diff/5001/doc/go_spec.html File doc/go_spec.html (right): https://codereview.appspot.com/6854096/diff/5001/doc/go_spec.html#newcode3 doc/go_spec.html:3: "Subtitle": "Version of November 21, 2012", s/21/26/

12 years, 6 months ago (2012-11-26 17:00:44 UTC) #2

rsc

12 years, 6 months ago (2012-11-26 20:43:38 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=6c34332cb98b ***

spec: add () to method calls in examples

Since p.M is rejected (must call methods), use p.M(),
to keep the examples compiling.

Fixes issue 4441.

R=gri
CC=golang-dev
http://codereview.appspot.com/6854096

Expand All Messages | Collapse All Messages