code review 6854068: gri

exp/types: don't test importing types if using gccgo

The exp/types packages does not support the gccgo export data
format.  At some point it should, but not yet.

[iant, 2012-11-20 00:35:53]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[bradfitz, 2012-11-20 00:50:26]

Bad description?

t.Logf("skipping test blah blah blah") ?
 On Nov 19, 2012 4:36 PM, <iant@golang.org> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> gri
>
> Please review this at
http://codereview.appspot.com/**6854068/<http://codereview.appspot.com/6854068/>
>
> Affected files:
>   M src/pkg/exp/types/gcimporter_**test.go
>
>
> Index: src/pkg/exp/types/gcimporter_**test.go
> ==============================**==============================**=======
> --- a/src/pkg/exp/types/**gcimporter_test.go
> +++ b/src/pkg/exp/types/**gcimporter_test.go
> @@ -127,6 +127,9 @@
>  }
>
>  func TestGcImportedTypes(t *testing.T) {
> +       if runtime.Compiler == "gccgo" {
> +               return
> +       }
>         for _, test := range importedObjectTests {
>                 s := strings.Split(test.name, ".")
>                 if len(s) != 2 {
>
>
>

[r, 2012-11-20 01:06:00]

you don't like gri??

-rob

[iant2, 2012-11-20 01:16:11]

On Mon, Nov 19, 2012 at 4:50 PM, Brad Fitzpatrick <bradfitz@golang.org> wrote:
> Bad description?
>
> t.Logf("skipping test blah blah blah") ?

Yeah, I haven't made that mistake for a whle.

I caught it quickly and ran hg change, but I forgot to run hg upload.
Should be better now.

Ian

> On Nov 19, 2012 4:36 PM, <iant@golang.org> wrote:
>>
>> Reviewers: golang-dev_googlegroups.com,
>>
>> Message:
>> Hello golang-dev@googlegroups.com,
>>
>> I'd like you to review this change to
>> https://go.googlecode.com/hg/
>>
>>
>> Description:
>> gri
>>
>> Please review this at http://codereview.appspot.com/6854068/
>>
>> Affected files:
>>   M src/pkg/exp/types/gcimporter_test.go
>>
>>
>> Index: src/pkg/exp/types/gcimporter_test.go
>> ===================================================================
>> --- a/src/pkg/exp/types/gcimporter_test.go
>> +++ b/src/pkg/exp/types/gcimporter_test.go
>> @@ -127,6 +127,9 @@
>>  }
>>
>>  func TestGcImportedTypes(t *testing.T) {
>> +       if runtime.Compiler == "gccgo" {
>> +               return
>> +       }
>>         for _, test := range importedObjectTests {
>>                 s := strings.Split(test.name, ".")
>>                 if len(s) != 2 {
>>
>>
>

[r, 2012-11-20 01:19:04]

LGTM
but i'm not gri

[dsymonds, 2012-11-20 01:21:07]

LGTM

but could do with a comment if this is expected to work at a later date.

[iant, 2012-11-20 05:56:28]

*** Submitted as http://code.google.com/p/go/source/detail?r=2524ef4a77b4 ***

exp/types: don't test importing types if using gccgo

The exp/types packages does not support the gccgo export data
format.  At some point it should, but not yet.

R=gri, bradfitz, r, iant, dsymonds
CC=golang-dev
http://codereview.appspot.com/6854068

[gri, 2012-11-20 06:12:26]

LGTM