Issue 6852062: code review 6852062: go/ast: FuncType.Params may be nil (per AST documentation)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6852062: code review 6852062: go/ast: FuncType.Params may be nil (per AST documentation) (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 8 months ago by gri

Modified:
12 years, 8 months ago

Reviewers:

CC:
r, golang-dev

Visibility:
Public.

Description

go/ast: FuncType.Params may be nil (per AST documentation) ast.Walk needs to check for it or it will crash.

Patch Set 1 #

Patch Set 2 : diff -r d464317cf047 https://code.google.com/p/go #

Created: 12 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	src/pkg/go/ast/walk.go	View		1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

gri

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

12 years, 8 months ago (2012-11-16 19:07:46 UTC) #1

gri

12 years, 8 months ago (2012-11-16 19:53:32 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=821585f8baba ***

go/ast: FuncType.Params may be nil (per AST documentation)

ast.Walk needs to check for it or it will crash.

R=r
CC=golang-dev
http://codereview.appspot.com/6852062

Expand All Messages | Collapse All Messages