Issue 6851098: code review 6851098: net: do not start io if deadline has passed

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6851098: code review 6851098: net: do not start io if deadline has passed (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 5 months ago by brainman

Modified:
11 years, 5 months ago

Reviewers:

CC:
golang-dev, mikio, minux1, bradfitz

Visibility:
Public.

Description

net: do not start io if deadline has passed

Patch Set 2 : diff -r f2755950769b https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r f2755950769b https://go.googlecode.com/hg/ #

Total comments: 2

Patch Set 4 : diff -r a17f2ff31447 https://go.googlecode.com/hg/ #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -6 lines)			Patch
	M	src/pkg/net/fd_windows.go	View	1 2 3	2 chunks	+11 lines, -6 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

brainman

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

11 years, 5 months ago (2012-11-23 01:40:31 UTC) #1

brainman

On 2012/11/23 04:17:43, mikio wrote: > LGTM Thank you. I will leave it for a ...

11 years, 5 months ago (2012-11-23 06:30:44 UTC) #3

minux1

could this be tested? https://codereview.appspot.com/6851098/diff/5001/src/pkg/net/fd_windows.go File src/pkg/net/fd_windows.go (right): https://codereview.appspot.com/6851098/diff/5001/src/pkg/net/fd_windows.go#newcode177 src/pkg/net/fd_windows.go:177: if delta < 1 { ...

11 years, 5 months ago (2012-11-23 12:04:01 UTC) #4

bradfitz

On Fri, Nov 23, 2012 at 4:04 AM, <minux.ma@gmail.com> wrote: > could this be tested? ...

11 years, 5 months ago (2012-11-24 02:17:57 UTC) #5

brainman

11 years, 5 months ago (2012-11-24 23:03:06 UTC) #6

*** Submitted as http://code.google.com/p/go/source/detail?r=14b544194509 ***

net: do not start io if deadline has passed

R=golang-dev, mikioh.mikioh, minux.ma, bradfitz
CC=golang-dev
http://codereview.appspot.com/6851098

http://codereview.appspot.com/6851098/diff/5001/src/pkg/net/fd_windows.go
File src/pkg/net/fd_windows.go (right):

http://codereview.appspot.com/6851098/diff/5001/src/pkg/net/fd_windows.go#new...
src/pkg/net/fd_windows.go:177: if delta < 1 {
delta cannot be less than 1. Silly me. Got rid of the check.

Expand All Messages | Collapse All Messages