code review 6849057: runtime: hide mheap from race detector

runtime: hide mheap from race detector
This significantly decreases amount of shadow memory
mapped by race detector.
I haven't tested on Windows, but on Linux it reduces
virtual memory size from 1351m to 330m for fmt.test.
Fixes issue 4379.

[dvyukov, 2012-11-15 12:08:29]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://dvyukov%40google.com@code.google.com/p/go/

[brainman, 2012-11-16 01:35:30]

Tested on windows, and it does fixes issue 4379. It also decreases (for
executable build with -race) committed memory usage significantly. For example
for "godoc -http=..." process total committed memory goes from 1737M to 686M.

Cannot say much about your change, because I do not know the system enough.

Thank you.

Alex

[dvyukov, 2012-11-16 08:08:54]

Ping.
I should fix the windows builder.

[dvyukov, 2012-11-16 08:12:20]

On 2012/11/16 01:35:30, brainman wrote:
> Tested on windows, and it does fixes issue 4379. It also decreases (for
> executable build with -race) committed memory usage significantly. For example
> for "godoc -http=..." process total committed memory goes from 1737M to 686M.
> 
> Cannot say much about your change, because I do not know the system enough.

Thanks for testing!

I think that eventually we need to add to windows/darwin amd64 builder machines
additional script with 'go test -race -short std'. The goal of that will be to
test the race detector itself, since it's going to be an official feature in
Go1.1.

[iant, 2012-11-16 16:00:26]

LGTM

[dvyukov, 2012-11-16 16:06:31]

*** Submitted as http://code.google.com/p/go/source/detail?r=d464317cf047 ***

runtime: hide mheap from race detector
This significantly decreases amount of shadow memory
mapped by race detector.
I haven't tested on Windows, but on Linux it reduces
virtual memory size from 1351m to 330m for fmt.test.
Fixes issue 4379.

R=golang-dev, alex.brainman, iant
CC=golang-dev
http://codereview.appspot.com/6849057