Issue 6846085: net/http: use runtime.Stack instead of runtime/debug.Stack

Issue 6846085: net/http: use runtime.Stack instead of runtime/debug.Stack (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 5 months ago by dfc

Modified:
11 years, 5 months ago

Reviewers:

CC:
golang-dev, dsymonds

Visibility:
Public.

Description

net/http: use runtime.Stack instead of runtime/debug.Stack Fixes issue 4060. 2012/11/21 19:51:34 http: panic serving 127.0.0.1:47139: Kaaarn! goroutine 7 [running]: net/http.func·004(0x7f330807ffb0, 0x7f330807f100) /home/dfc/go/src/pkg/net/http/server.go:615 +0xa7 ----- stack segment boundary ----- main.(*httpHandler).ServeHTTP() /home/dfc/src/httppanic.go:16 +0x53 net/http.(*conn).serve(0xc200090240, 0x0) /home/dfc/go/src/pkg/net/http/server.go:695 +0x55d created by net/http.(*Server).Serve /home/dfc/go/src/pkg/net/http/server.go:1119 +0x36d

Patch Set 1 #

Patch Set 2 : diff -r 2a55e349097f https://code.google.com/p/go #

Patch Set 3 : diff -r 2a55e349097f https://code.google.com/p/go #

Patch Set 4 : diff -r 2a55e349097f https://code.google.com/p/go #

Total comments: 4

Patch Set 5 : diff -r 2a4a89b1f36b https://go.googlecode.com/hg/ #

Patch Set 6 : diff -r dfb4a24735c0 https://go.googlecode.com/hg/ #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -6 lines)			Patch
	M	src/pkg/net/http/server.go	View	1 2 3 4	3 chunks	+5 lines, -6 lines	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

dfc

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

11 years, 5 months ago (2012-11-21 08:54:36 UTC) #1

dfc

Thank you. PTAL. On Wed, Nov 21, 2012 at 9:07 PM, David Symonds <dsymonds@golang.org> wrote: ...

11 years, 5 months ago (2012-11-21 10:12:50 UTC) #3

dsymonds

LGTM https://codereview.appspot.com/6846085/diff/5002/src/pkg/net/http/server.go File src/pkg/net/http/server.go (right): https://codereview.appspot.com/6846085/diff/5002/src/pkg/net/http/server.go#newcode612 src/pkg/net/http/server.go:612: const size = 1 << 12 I might ...

11 years, 5 months ago (2012-11-21 11:57:28 UTC) #4

dfc

Thanks for your comments, PTAL. https://codereview.appspot.com/6846085/diff/5002/src/pkg/net/http/server.go File src/pkg/net/http/server.go (right): https://codereview.appspot.com/6846085/diff/5002/src/pkg/net/http/server.go#newcode612 src/pkg/net/http/server.go:612: const size = 1 ...

11 years, 5 months ago (2012-11-21 12:07:52 UTC) #5

dfc

11 years, 5 months ago (2012-11-21 21:19:00 UTC) #7

*** Submitted as http://code.google.com/p/go/source/detail?r=be66ed00e1a0 ***

net/http: use runtime.Stack instead of runtime/debug.Stack

Fixes issue 4060.

2012/11/21 19:51:34 http: panic serving 127.0.0.1:47139: Kaaarn!
goroutine 7 [running]:
net/http.func·004(0x7f330807ffb0, 0x7f330807f100)
	/home/dfc/go/src/pkg/net/http/server.go:615 +0xa7
----- stack segment boundary -----
main.(*httpHandler).ServeHTTP()
	/home/dfc/src/httppanic.go:16 +0x53
net/http.(*conn).serve(0xc200090240, 0x0)
	/home/dfc/go/src/pkg/net/http/server.go:695 +0x55d
created by net/http.(*Server).Serve
	/home/dfc/go/src/pkg/net/http/server.go:1119 +0x36d

R=golang-dev, dsymonds
CC=golang-dev
http://codereview.appspot.com/6846085

Expand All Messages | Collapse All Messages