Issue 6843067: code review 6843067: re2: Wrap unguarded uses of LOG(ERROR), testing options...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6843067: code review 6843067: re2: Wrap unguarded uses of LOG(ERROR), testing options...

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 5 months ago by jmillikin

Modified:
13 years, 4 months ago

Reviewers:
rsc

CC:
rsc, re2-dev_googlegroups.com

Visibility:
Public.

Description

re2: Wrap unguarded uses of LOG(ERROR), testing options.log_errors(). Most uses were already guarded, but a few were not, and were generating unwanted stderr output.

Patch Set 1 #

Patch Set 2 : diff -r 7bf5e87ef4e8 https://re2.googlecode.com/hg #

Patch Set 3 : diff -r 7bf5e87ef4e8 https://re2.googlecode.com/hg #

Created: 13 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -12 lines)			Patch
	M	re2/filtered_re2.cc	View	1	1 chunk	+4 lines, -2 lines	0 comments	Download
	M	re2/re2.cc	View	1	8 chunks	+16 lines, -10 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

jmillikin

Hello rsc@golang.org (cc: re2-dev@googlegroups.com), I'd like you to review this change to https://re2.googlecode.com/hg

13 years, 5 months ago (2012-11-16 04:25:03 UTC) #1

jmillikin

For reference, CLA isn't needed (AFAIK) because I'm a Googler.

13 years, 5 months ago (2012-11-16 04:27:12 UTC) #2

rsc

13 years, 4 months ago (2012-11-26 16:07:41 UTC) #4

*** Submitted as http://code.google.com/p/re2/source/detail?r=dd841cbcdafa ***

re2: Wrap unguarded uses of LOG(ERROR), testing options.log_errors().

Most uses were already guarded, but a few were not, and were generating
unwanted stderr output.

R=rsc
CC=re2-dev
http://codereview.appspot.com/6843067

Committer: Russ Cox <rsc@swtch.com>

Expand All Messages | Collapse All Messages