Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1092)

Issue 6843057: code review 6843057: debug/elf: fix offset for GNU version symbols (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 4 months ago by jsing
Modified:
11 years, 4 months ago
Reviewers:
CC:
golang-dev, agl1, iant2
Visibility:
Public.

Description

debug/elf: fix offset for GNU version symbols Since we no longer skip the first entry when reading a symbol table, we no longer need to allow for the offset difference when processing the GNU version symbols. Unbreaks builds on Linux.

Patch Set 1 #

Patch Set 2 : diff -r 9ea9e7e6e0c8 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 9ea9e7e6e0c8 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 9ea9e7e6e0c8 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/pkg/debug/elf/file.go View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4
jsing
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
11 years, 4 months ago (2012-11-14 16:20:30 UTC) #1
agl1
LGTM if it unbreaks the build.
11 years, 4 months ago (2012-11-14 16:27:12 UTC) #2
iant2
LGTM On Wed, Nov 14, 2012 at 8:20 AM, <jsing@google.com> wrote: > Reviewers: golang-dev_googlegroups.com, > ...
11 years, 4 months ago (2012-11-14 16:37:26 UTC) #3
jsing
11 years, 4 months ago (2012-11-14 16:39:29 UTC) #4
*** Submitted as http://code.google.com/p/go/source/detail?r=76ff7da868c6 ***

debug/elf: fix offset for GNU version symbols

Since we no longer skip the first entry when reading a symbol table,
we no longer need to allow for the offset difference when processing
the GNU version symbols.

Unbreaks builds on Linux.

R=golang-dev, agl, iant
CC=golang-dev
http://codereview.appspot.com/6843057
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b