Issue 6842089: code review 6842089: devdraw: restore compilation on OS X 10.6

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6842089: code review 6842089: devdraw: restore compilation on OS X 10.6 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 1 month ago by minux1

Modified:
12 years, 1 month ago

Reviewers:

CC:
rsc

Visibility:
Public.

Description

devdraw: restore compilation on OS X 10.6 Also add some ignored files to .hgignore

Patch Set 1 #

Patch Set 2 : diff -r d82a86de23fa https://code.google.com/p/plan9port/ #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -0 lines)			Patch
	M	.hgignore	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download
	M	src/cmd/devdraw/cocoa-screen.m	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

minux1

Hello rsc@golang.org, I'd like you to review this change to https://code.google.com/p/plan9port/

12 years, 1 month ago (2012-11-23 19:53:04 UTC) #1

rsc

12 years, 1 month ago (2012-11-26 02:24:53 UTC) #2

*** Submitted as http://code.google.com/p/plan9port/source/detail?r=b317fb6e7e19
***

devdraw: restore compilation on OS X 10.6
Also add some ignored files to .hgignore

R=rsc
http://codereview.appspot.com/6842089

Committer: Russ Cox <rsc@swtch.com>

Expand All Messages | Collapse All Messages