Issue 6840043: code review 6840043: archive/tar: accept binary format when reading numeric ...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6840043: code review 6840043: archive/tar: accept binary format when reading numeric ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 9 months ago by dsymonds

Modified:
12 years, 9 months ago

Reviewers:

CC:
golang-dev, r

Visibility:
Public.

Description

archive/tar: accept binary format when reading numeric header fields. Fixes issue 4358.

Patch Set 2 : diff -r a53601cd4e63 https://code.google.com/p/go #

Patch Set 3 : diff -r a53601cd4e63 https://code.google.com/p/go #

Total comments: 2

Patch Set 4 : diff -r ab868a8f3128 https://code.google.com/p/go #

Created: 12 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -0 lines)			Patch
	M	src/pkg/archive/tar/reader.go	View	1	1 chunk	+12 lines, -0 lines	0 comments	Download
	M	src/pkg/archive/tar/tar_test.go	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

dsymonds

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

12 years, 9 months ago (2012-11-08 00:51:38 UTC) #1

http://codereview.appspot.com/6840043/diff/5001/src/pkg/archive/tar/reader.go File src/pkg/archive/tar/reader.go (right): http://codereview.appspot.com/6840043/diff/5001/src/pkg/archive/tar/reader.go#newcode75 src/pkg/archive/tar/reader.go:75: // Check for binary format first. who says this ...

12 years, 9 months ago (2012-11-08 00:56:57 UTC) #2

dsymonds

https://codereview.appspot.com/6840043/diff/5001/src/pkg/archive/tar/reader.go File src/pkg/archive/tar/reader.go (right): https://codereview.appspot.com/6840043/diff/5001/src/pkg/archive/tar/reader.go#newcode75 src/pkg/archive/tar/reader.go:75: // Check for binary format first. On 2012/11/08 00:56:57, ...

12 years, 9 months ago (2012-11-08 00:59:40 UTC) #3

dsymonds

12 years, 9 months ago (2012-11-08 21:50:11 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=c8d869358e07 ***

archive/tar: accept binary format when reading numeric header fields.

Fixes issue 4358.

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/6840043

Expand All Messages | Collapse All Messages