Issue 6829043: code review 6829043: goprotobuf: Don't treat groups as messages.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6829043: code review 6829043: goprotobuf: Don't treat groups as messages. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years ago by dsymonds

Modified:
13 years ago

Reviewers:

CC:
nigeltao, r, golang-dev

Visibility:
Public.

Description

goprotobuf: Don't treat groups as messages. They no longer get XXX_unrecognized fields, nor satisfy the proto.Message interface.

Patch Set 1 #

Patch Set 2 : diff -r b4e0dd8d9920 https://code.google.com/p/goprotobuf #

Patch Set 3 : diff -r b4e0dd8d9920 https://code.google.com/p/goprotobuf #

Patch Set 4 : diff -r b4e0dd8d9920 https://code.google.com/p/goprotobuf #

Patch Set 5 : diff -r b4e0dd8d9920 https://code.google.com/p/goprotobuf #

Created: 13 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+73 lines, -22 lines)			Patch
M	proto/clone.go	View	1	1 chunk	+6 lines, -1 line	0 comments	Download
M	proto/clone_test.go	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	proto/equal.go	View	1	1 chunk	+7 lines, -1 line	0 comments	Download
M	proto/equal_test.go	View	1	1 chunk	+17 lines, -0 lines	0 comments	Download
M	protoc-gen-go/generator/generator.go	View	1	7 chunks	+36 lines, -10 lines	0 comments	Download
M	protoc-gen-go/testdata/my_test/test.pb.go	View	1 2	1 chunk	+2 lines, -5 lines	0 comments	Download
M	protoc-gen-go/testdata/my_test/test.pb.go.golden	View	1 2	1 chunk	+2 lines, -5 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

dsymonds

Hello nigeltao (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/goprotobuf

13 years ago (2012-11-07 00:19:21 UTC) #1

dsymonds

Hello nigeltao@golang.org, r (cc: golang-dev@googlegroups.com), Please take another look.

13 years ago (2012-11-07 00:39:19 UTC) #2

dsymonds

13 years ago (2012-11-07 00:43:01 UTC) #4

*** Submitted as
http://code.google.com/p/goprotobuf/source/detail?r=d2c1b0633ec3 ***

goprotobuf: Don't treat groups as messages.

They no longer get XXX_unrecognized fields, nor satisfy the proto.Message
interface.

R=nigeltao, r
CC=golang-dev
http://codereview.appspot.com/6829043

Expand All Messages | Collapse All Messages