Issue 6826063: code review 6826063: reflect: fix test of whether structs are identical

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6826063: code review 6826063: reflect: fix test of whether structs are identical (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 8 months ago by iant

Modified:
12 years, 8 months ago

Reviewers:

CC:
rsc, gobot, golang-dev

Visibility:
Public.

Description

reflect: fix test of whether structs are identical The old code worked with gc, I assume because the linker unified identical strings, but it failed with gccgo.

Patch Set 1 #

Patch Set 2 : diff -r b661b713984f https://go.googlecode.com/hg/ #

Created: 12 years, 8 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Stats (+55 lines, -2 lines)			Patch
src/pkg/reflect/type.go	View	1 chunk	+13 lines, -2 lines	0 comments	Download
test/fixedbugs/bug468.go	View	1 chunk	+10 lines, -0 lines	0 comments	Download
test/fixedbugs/bug468.dir/p1.go	View	1 chunk	+7 lines, -0 lines	0 comments	Download
test/fixedbugs/bug468.dir/p2.go	View	1 chunk	+25 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

iant

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 8 months ago (2012-11-07 01:30:52 UTC) #1

iant

12 years, 8 months ago (2012-11-07 19:55:41 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=ff7ca53f4433 ***

reflect: fix test of whether structs are identical

The old code worked with gc, I assume because the linker
unified identical strings, but it failed with gccgo.

R=rsc
CC=gobot, golang-dev
http://codereview.appspot.com/6826063

Expand All Messages | Collapse All Messages