Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(101)

Issue 6823058: Fix relations between \maininput, EOF and safe mode (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 5 months ago by dak
Modified:
11 years, 4 months ago
Reviewers:
janek
CC:
lilypond-devel_gnu.org
Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/
Visibility:
Public.

Description

Fix relations between \maininput, EOF and safe mode In lexer.ll, assumptions about the depth of include_stack_ were hardwired that only were valid for parsers started from the normal chain of input. One consequence was that something like #{ \book { \include "line-arrows.ly" } #} worked even in safe mode (where \include should be prohibited) but might complain about unexpected EOF. This commit adds a member variable main_input_level to Lily_lexer for keeping track of when to drop restrictions and deliver EOF in each parser separately.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M lily/include/lily-lexer.hh View 1 chunk +1 line, -0 lines 0 comments Download
M lily/lexer.ll View 2 chunks +5 lines, -6 lines 0 comments Download
M lily/lily-lexer.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 1
janek
11 years, 4 months ago (2012-11-02 08:32:07 UTC) #1
LGTM i guess.
As usual, in case of me reviewing scheme or parser stuff, it just means "i
haven't spotted anything obviously wrong and i can understand the description".

Janek
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b