code review 6823044: misc/vim: fix reimport guard and remove K mapping.

misc/vim: fix reimport guard and remove K mapping.

The "did_ftplugin" lines were ineffective and the "K" mapping was too
invasive, which is why it was removed.

[AndrewRadev, 2012-10-29 10:11:54]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[dsymonds, 2012-10-29 10:18:10]

Thanks, but can you sign the CLA?

http://golang.org/doc/contribute.html#copyright

Let me know when you've done that and I'll prepare the A+C changes.

[dsymonds, 2012-10-29 10:21:10]

https://codereview.appspot.com/6823044/diff/4001/misc/vim/ftplugin/go/fmt.vim
File misc/vim/ftplugin/go/fmt.vim (right):

https://codereview.appspot.com/6823044/diff/4001/misc/vim/ftplugin/go/fmt.vim...
misc/vim/ftplugin/go/fmt.vim:15: if exists("b:did_ftplugin_fmt")
let's use "b:did_ftplugin_go_fmt" to mirror the path.

https://codereview.appspot.com/6823044/diff/4001/misc/vim/ftplugin/go/import.vim
File misc/vim/ftplugin/go/import.vim (right):

https://codereview.appspot.com/6823044/diff/4001/misc/vim/ftplugin/go/import....
misc/vim/ftplugin/go/import.vim:35: if exists("b:did_ftplugin_import")
"b:did_ftplugin_go_import"

[AndrewRadev, 2012-10-29 10:33:39]

Hello golang-dev@googlegroups.com, dsymonds@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[dsymonds, 2012-10-29 10:34:50]

LGTM

[minux1, 2012-10-29 10:38:24]

you didn't remove the K mapping.

[dsymonds, 2012-10-29 10:40:09]

On Mon, Oct 29, 2012 at 9:38 PM,  <minux.ma@gmail.com> wrote:

> you didn't remove the K mapping.

Aah, yes. Please do that, and change the first line of the CL
description to read
  misc/vim: fix reimport guard and remove K mapping.

[AndrewRadev, 2012-10-29 10:46:31]

Hello golang-dev@googlegroups.com, dsymonds@golang.org, minux.ma@gmail.com (cc:
golang-dev@googlegroups.com),

Please take another look.

[dsymonds, 2012-10-29 10:51:09]

I don't see the K mapping gone. You need to do a "hg upload 6823044" to push
your local changes to Rietveld.

[minux1, 2012-10-29 10:53:36]

you need to add newly changed file to this CL, for example:
hg file 6823044 misc/vim/plugin/godoc.vim misc/vim/ftplugin/go/godoc.vim

and then redo 'hg mail 6823044'.

[AndrewRadev, 2012-10-29 11:00:49]

Hello golang-dev@googlegroups.com, dsymonds@golang.org, minux.ma@gmail.com (cc:
golang-dev@googlegroups.com),

Please take another look.

[dsymonds, 2012-10-29 11:05:58]

please update misc/vim/readme.txt too.

[AndrewRadev, 2012-10-29 11:07:48]

Hello golang-dev@googlegroups.com, dsymonds@golang.org, minux.ma@gmail.com (cc:
golang-dev@googlegroups.com),

Please take another look.

[dsymonds, 2012-10-29 11:08:17]

LGTM

thanks

[dsymonds, 2012-10-29 11:10:59]

*** Submitted as http://code.google.com/p/go/source/detail?r=507eeea1c3da ***

misc/vim: fix reimport guard and remove K mapping.

The "did_ftplugin" lines were ineffective and the "K" mapping was too
invasive, which is why it was removed.

R=golang-dev, dsymonds, minux.ma
CC=golang-dev
http://codereview.appspot.com/6823044

Committer: David Symonds <dsymonds@golang.org>