Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(119)

Issue 6822111: code review 6822111: faq: mention go vet in "What happens with closures runn... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 6 months ago by chressie1
Modified:
12 years, 6 months ago
Reviewers:
CC:
r, golang-dev
Visibility:
Public.

Description

faq: mention go vet in "What happens with closures running as goroutines?"

Patch Set 1 #

Patch Set 2 : diff -r f5c69f87ef34 https://code.google.com/p/go #

Patch Set 3 : diff -r f5c69f87ef34 https://code.google.com/p/go #

Total comments: 2

Patch Set 4 : diff -r f5c69f87ef34 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M doc/go_faq.html View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5
chressie1
Hello r@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
12 years, 6 months ago (2012-11-12 14:23:43 UTC) #1
r
http://codereview.appspot.com/6822111/diff/5001/doc/go_faq.html File doc/go_faq.html (right): http://codereview.appspot.com/6822111/diff/5001/doc/go_faq.html#newcode1265 doc/go_faq.html:1265: The <code>go vet</code> tool can help to detect these ...
12 years, 6 months ago (2012-11-12 15:08:27 UTC) #2
chressie1
PTAL https://codereview.appspot.com/6822111/diff/5001/doc/go_faq.html File doc/go_faq.html (right): https://codereview.appspot.com/6822111/diff/5001/doc/go_faq.html#newcode1265 doc/go_faq.html:1265: The <code>go vet</code> tool can help to detect ...
12 years, 6 months ago (2012-11-12 15:20:59 UTC) #3
r
LGTM
12 years, 6 months ago (2012-11-12 15:25:20 UTC) #4
r
12 years, 6 months ago (2012-11-12 15:26:13 UTC) #5
*** Submitted as http://code.google.com/p/go/source/detail?r=7f01aa945e3f ***

faq: mention go vet in "What happens with closures running as goroutines?"

R=r
CC=golang-dev
http://codereview.appspot.com/6822111

Committer: Rob Pike <r@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b