Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3451)

Issue 6822083: code review 6822083: go.net/ipv4: make supportsNewIPInput const (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 5 months ago by mikio
Modified:
11 years, 5 months ago
Reviewers:
CC:
dave_cheney.net, golang-dev
Visibility:
Public.

Description

go.net/ipv4: make supportsNewIPInput const

Patch Set 1 #

Patch Set 2 : diff -r c6c20fbea877 https://code.google.com/p/go.net #

Patch Set 3 : diff -r c6c20fbea877 https://code.google.com/p/go.net #

Patch Set 4 : diff -r c6c20fbea877 https://code.google.com/p/go.net #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ipv4/header.go View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
mikio
Hello dave@cheney.net (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.net
11 years, 5 months ago (2012-11-06 11:08:55 UTC) #1
dave_cheney.net
LGTM. Nice. On Tue, Nov 6, 2012 at 10:08 PM, <mikioh.mikioh@gmail.com> wrote: > Reviewers: dfc, ...
11 years, 5 months ago (2012-11-06 11:36:57 UTC) #2
mikio
11 years, 5 months ago (2012-11-06 13:00:23 UTC) #3
*** Submitted as
http://code.google.com/p/go/source/detail?r=47329b7c166c&repo=net ***

go.net/ipv4: make supportsNewIPInput const

R=dave
CC=golang-dev
http://codereview.appspot.com/6822083
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b