Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4)

Issue 6822068: code review 6822068: exp/types: move exp/types/staging -> exp/types (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 9 months ago by gri
Modified:
12 years, 9 months ago
Reviewers:
CC:
iant, golang-dev
Visibility:
Public.

Description

exp/types: move exp/types/staging -> exp/types - removes exp/types/staging - the only code change is in exp/gotype/gotype.go

Patch Set 1 #

Patch Set 2 : diff -r 552de92fb497 https://code.google.com/p/go #

Patch Set 3 : diff -r 552de92fb497 https://code.google.com/p/go #

Patch Set 4 : diff -r 552de92fb497 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-29 lines, --29 lines) Patch
M src/pkg/exp/gotype/gotype.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/exp/types/builtins.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/exp/types/check.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/exp/types/check_test.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/exp/types/const.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/exp/types/conversions.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/exp/types/errors.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/exp/types/exportdata.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/exp/types/expr.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/exp/types/gcimporter.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/exp/types/gcimporter_test.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/exp/types/operand.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/exp/types/predicates.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/exp/types/resolver_test.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/exp/types/stmt.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/exp/types/testdata/builtins.src View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/exp/types/testdata/const0.src View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/exp/types/testdata/conversions.src View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/exp/types/testdata/decls0.src View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/exp/types/testdata/decls1.src View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/exp/types/testdata/decls2a.src View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/exp/types/testdata/decls2b.src View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/exp/types/testdata/exports.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/exp/types/testdata/expr0.src View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/exp/types/testdata/expr1.src View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/exp/types/testdata/expr2.src View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/exp/types/testdata/expr3.src View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/exp/types/testdata/stmt0.src View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/exp/types/types.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/exp/types/types_test.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/exp/types/universe.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 3
gri
Hello iant@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
12 years, 9 months ago (2012-11-01 22:32:57 UTC) #1
iant
LGTM
12 years, 9 months ago (2012-11-01 22:35:05 UTC) #2
gri
12 years, 9 months ago (2012-11-01 22:38:21 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=62cc4df87a0f ***

exp/types: move exp/types/staging -> exp/types

- removes exp/types/staging
- the only code change is in exp/gotype/gotype.go

R=iant
CC=golang-dev
http://codereview.appspot.com/6822068
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b