Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(646)

Issue 6822048: code review 6822048: cmd/gc: racewalk: fix a bunch of minor issues (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 9 months ago by dvyukov
Modified:
12 years, 9 months ago
Reviewers:
CC:
golang-dev, rsc
Visibility:
Public.

Description

cmd/gc: racewalk: fix a bunch of minor issues 1. Prepend racefuncenter() to fn->enter -- fn->enter can contain new() calls, and we want them to be in the scope of the function. 2. Dump fn->enter and fn->exit. 3. Add TODO that OTYPESW expression can contain interesting memory accesses. 4. Ignore only _ names instead of all names starting with _.

Patch Set 1 #

Patch Set 2 : diff -r d2f3c74b9998 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r d2f3c74b9998 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r d2f3c74b9998 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 8ddb4ef42650 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 6 : diff -r 8ddb4ef42650 https://dvyukov%40google.com@code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -4 lines) Patch
M src/cmd/gc/racewalk.c View 1 2 3 4 5 chunks +16 lines, -4 lines 0 comments Download

Messages

Total messages: 3
dvyukov
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
12 years, 9 months ago (2012-10-29 19:02:28 UTC) #1
rsc
LGTM
12 years, 9 months ago (2012-11-01 16:59:00 UTC) #2
dvyukov
12 years, 9 months ago (2012-11-01 18:56:21 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=e9002d732849 ***

cmd/gc: racewalk: fix a bunch of minor issues
1. Prepend racefuncenter() to fn->enter -- fn->enter can contain new() calls,
and we want them to be in the scope of the function.
2. Dump fn->enter and fn->exit.
3. Add TODO that OTYPESW expression can contain interesting memory accesses.
4. Ignore only _ names instead of all names starting with _.

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/6822048
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b