Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3)

Issue 6821062: code review 6821062: net: do not test TestReadWriteDeadline timeout upper bo... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 9 months ago by brainman
Modified:
12 years, 9 months ago
Reviewers:
minux1
CC:
golang-dev
Visibility:
Public.

Description

net: do not test TestReadWriteDeadline timeout upper bound during short test It also increases timeout deltas to allow for longer wait. Also disables this test on plan9.

Patch Set 1 #

Patch Set 2 : diff -r fb1b882732d5 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r fb1b882732d5 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 5bc48b616305 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 5bc48b616305 https://go.googlecode.com/hg/ #

Patch Set 6 : diff -r a9b2f3280559 https://go.googlecode.com/hg/ #

Total comments: 2

Patch Set 7 : diff -r 126c37a9e33c https://go.googlecode.com/hg/ #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -4 lines) Patch
M src/pkg/net/ipsock_plan9.go View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M src/pkg/net/timeout_test.go View 1 4 5 6 1 chunk +9 lines, -4 lines 1 comment Download

Messages

Total messages: 7
brainman
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
12 years, 9 months ago (2012-11-01 01:48:47 UTC) #1
brainman
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), Please take another look.
12 years, 9 months ago (2012-11-01 02:17:08 UTC) #2
brainman
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), Please take another look.
12 years, 9 months ago (2012-11-01 04:39:25 UTC) #3
brainman
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), Please take another look.
12 years, 9 months ago (2012-11-02 00:14:04 UTC) #4
minux1
LGTM. https://codereview.appspot.com/6821062/diff/1002/src/pkg/net/timeout_test.go File src/pkg/net/timeout_test.go (right): https://codereview.appspot.com/6821062/diff/1002/src/pkg/net/timeout_test.go#newcode181 src/pkg/net/timeout_test.go:181: var err error why add this? i think ...
12 years, 9 months ago (2012-11-03 20:54:25 UTC) #5
brainman
*** Submitted as http://code.google.com/p/go/source/detail?r=1c41ea55cca9 *** net: do not test TestReadWriteDeadline timeout upper bound during short ...
12 years, 9 months ago (2012-11-04 01:41:59 UTC) #6
minux1
12 years, 9 months ago (2012-11-04 09:32:11 UTC) #7
https://codereview.appspot.com/6821062/diff/5004/src/pkg/net/timeout_test.go
File src/pkg/net/timeout_test.go (right):

https://codereview.appspot.com/6821062/diff/5004/src/pkg/net/timeout_test.go#...
src/pkg/net/timeout_test.go:167: d := should - is
my bad, i think this line should be:
d := is - should
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b