Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(233)

Issue 6819066: Gobble empty strings passed as arguments to python scripts. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 5 months ago by Julien Rioux
Modified:
11 years, 5 months ago
Reviewers:
janek, dak
CC:
lilypond-devel_gnu.org
Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/
Visibility:
Public.

Description

Gobble empty strings passed as arguments to python scripts. This is needed on windows in combination with the fix to issue 1455. Either we go this way, or we revert the fix to issue 1455. Should also be considered a candidate for the 2.16 stable branch.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M python/lilylib.py View 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 2
janek
I think it would be helpful to not-so-advanced English speakers if a word more ordinary ...
11 years, 5 months ago (2012-11-05 10:58:37 UTC) #1
dak
11 years, 5 months ago (2012-11-05 11:13:44 UTC) #2
On 2012/11/05 10:58:37, janek wrote:
> I think it would be helpful to not-so-advanced English speakers if a word more
> ordinary than "gobble" was used.

I am not sure of that.  "gobble" is actually pretty established in programmer
jargon:

From The Jargon File (version 4.4.7, 29 Dec 2003) [jargon]:

  gobble
   vt.
  
      1. To consume, usu.: used with ?up?. ?The output spy gobbles characters
out
      of a {tty} output buffer.?
  
      2. To obtain, usu.: used with ?down?. ?I guess I'll gobble down a copy of
      the documentation tomorrow.? See also {snarf}.
  

From The Free On-line Dictionary of Computing (26 July 2010) [foldoc]:

  gobble
  
     <jargon>
  
     1. To consume, usually used with "up".  "The output spy
     gobbles characters out of a {tty} output buffer."
  
     2. To obtain, usually used with "down".  "I guess I'll gobble
     down a copy of the documentation tomorrow."
  
     See also {snarf}.
  
     [{Jargon File}]
  
     (2010-01-19)

It has a rather well-established meaning.  The referenced "snarf" is even less
common in normal English usage, but is quite common for programmers (the
difference of snarfing to gobbling is that snarfed components are typically used
elsewhere while gobbled material is usually discarded).

So since the main audience of commit messages is supposed to be programmers, I
don't really think that the message will be improved by reverting to
non-standard terms better rooted in the Queen's English.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b