Issue 6818104: code review 6818104: cmd/api: bug fix for goapi's lame type checker

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6818104: code review 6818104: cmd/api: bug fix for goapi's lame type checker (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 5 months ago by bradfitz

Modified:
11 years, 5 months ago

Reviewers:

CC:
golang-dev, mikio

Visibility:
Public.

Description

cmd/api: bug fix for goapi's lame type checker This is blocking me submitting the net fd timeout CL, since goapi chokes on my constant. The much more extensive fix to goapi's type checker in pending review in https://codereview.appspot.com/6742050 But I'd rather get this quick fix in first.

Patch Set 1 #

Patch Set 2 : diff -r 61f28ec84870 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 61f28ec84870 https://go.googlecode.com/hg/ #

Total comments: 3

Patch Set 4 : diff -r 38937a8d0911 https://go.googlecode.com/hg/ #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -20 lines)			Patch
	M	src/cmd/api/goapi.go	View	1 2 3	3 chunks	+5 lines, -20 lines	0 comments	Download
	M	src/cmd/api/testdata/src/pkg/p1/p1.go	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

11 years, 5 months ago (2012-11-08 07:57:35 UTC) #1

mikio

LGTM https://codereview.appspot.com/6818104/diff/2002/src/cmd/api/goapi.go File src/cmd/api/goapi.go (right): https://codereview.appspot.com/6818104/diff/2002/src/cmd/api/goapi.go#newcode337 src/cmd/api/goapi.go:337: func (w *Walker) hardCodedConstantType(name string) (typ string, ok ...

11 years, 5 months ago (2012-11-08 11:45:43 UTC) #2

bradfitz

*** Submitted as http://code.google.com/p/go/source/detail?r=b68c8ef2a2e9 *** cmd/api: bug fix for goapi's lame type checker This is ...

11 years, 5 months ago (2012-11-08 16:35:00 UTC) #3

bradfitz

11 years, 5 months ago (2012-11-08 16:42:12 UTC) #4

https://codereview.appspot.com/6818104/diff/2002/src/cmd/api/goapi.go
File src/cmd/api/goapi.go (right):

https://codereview.appspot.com/6818104/diff/2002/src/cmd/api/goapi.go#newcode337
src/cmd/api/goapi.go:337: func (w *Walker) hardCodedConstantType(name string)
(typ string, ok bool) {
On 2012/11/08 11:45:43, mikio wrote:
> we don't need this anymore.

oh, great.

Expand All Messages | Collapse All Messages