Issue 6816103: code review 6816103: cmd/gc: fix escape analysis bug

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6816103: code review 6816103: cmd/gc: fix escape analysis bug (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 6 months ago by rsc

Modified:
12 years, 6 months ago

Reviewers:
ken3

CC:
ken2, golang-dev, lvd

Visibility:
Public.

Description

cmd/gc: fix escape analysis bug The code assumed that the only choices were EscNone, EscScope, and EscHeap, so that it makes sense to set EscScope only if the current setting is EscNone. Now that we have the many variants of EscReturn, this logic is false, and it was causing important EscScopes to be ignored in favor of EscReturn. Fixes issue 4360.

Patch Set 1 #

Patch Set 2 : diff -r 25dcee3d220c https://code.google.com/p/go/ #

Patch Set 3 : diff -r ca94b72025c5 https://code.google.com/p/go/ #

Created: 12 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -2 lines)			Patch
M	src/cmd/gc/esc.c	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/cmd/gc/subr.c	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	test/escape5.go	View	1	1 chunk	+25 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello ken2 (cc: golang-dev@googlegroups.com, lvd), I'd like you to review this change to https://code.google.com/p/go/

12 years, 6 months ago (2012-11-07 20:15:15 UTC) #1

rsc

*** Submitted as http://code.google.com/p/go/source/detail?r=8e1ebfcaee37 *** cmd/gc: fix escape analysis bug The code assumed that the ...

12 years, 6 months ago (2012-11-07 20:15:26 UTC) #2

lgtm

Expand All Messages | Collapse All Messages