Issue 6815081: code review 6815081: cmd/godoc: use normal gofmt printer settings for playgr...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6815081: code review 6815081: cmd/godoc: use normal gofmt printer settings for playgr... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 9 months ago by adg

Modified:
12 years, 9 months ago

Reviewers:

CC:
gri, golang-dev

Visibility:
Public.

Description

cmd/godoc: use normal gofmt printer settings for playground fmt

Patch Set 2 : diff -r f781c447da6e https://code.google.com/p/go #

Created: 12 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	src/cmd/godoc/play.go	View	1	1 chunk	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

adg

Hello gri (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

12 years, 9 months ago (2012-11-05 14:12:20 UTC) #1

gri

LGTM thanks. https://codereview.appspot.com/6815081/diff/1/src/cmd/godoc/play.go File src/cmd/godoc/play.go (right): https://codereview.appspot.com/6815081/diff/1/src/cmd/godoc/play.go#newcode52 src/cmd/godoc/play.go:52: var printConfig = printer.Config{Mode: printer.UseSpaces | printer.TabIndent, ...

12 years, 9 months ago (2012-11-05 16:47:49 UTC) #2

adg

12 years, 9 months ago (2012-11-05 21:46:33 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=98c502c5d1fb ***

cmd/godoc: use normal gofmt printer settings for playground fmt

R=gri
CC=golang-dev
http://codereview.appspot.com/6815081

Expand All Messages | Collapse All Messages