code review 6811069: net: add missing locking in windows Shutdown

net: add missing locking in windows Shutdown

[brainman, 2012-11-02 01:15:15]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[bradfitz, 2012-11-02 08:01:16]

LGTM
 On Nov 2, 2012 2:15 AM, <alex.brainman@gmail.com> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> net: add missing locking in windows Shutdown
>
> Please review this at
http://codereview.appspot.com/**6811069/<http://codereview.appspot.com/6811069/>
>
> Affected files:
>   M src/pkg/net/fd_windows.go
>
>
> Index: src/pkg/net/fd_windows.go
> ==============================**==============================**=======
> --- a/src/pkg/net/fd_windows.go
> +++ b/src/pkg/net/fd_windows.go
> @@ -371,9 +371,10 @@
>  }
>
>  func (fd *netFD) shutdown(how int) error {
> -       if fd == nil || fd.sysfd == syscall.InvalidHandle {
> -               return syscall.EINVAL
> +       if err := fd.incref(false); err != nil {
> +               return err
>         }
> +       defer fd.decref()
>         err := syscall.Shutdown(fd.sysfd, how)
>         if err != nil {
>                 return &OpError{"shutdown", fd.net, fd.laddr, err}
>
>
>

[brainman, 2012-11-02 09:46:58]

*** Submitted as http://code.google.com/p/go/source/detail?r=c0761b6a5160 ***

net: add missing locking in windows Shutdown

R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/6811069