Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(428)

Issue 6810093: code review 6810093: net: fix protocol number for IPv6 test (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 4 months ago by mikio
Modified:
11 years, 4 months ago
Reviewers:
CC:
golang-dev, bradfitz
Visibility:
Public.

Description

net: fix protocol number for IPv6 test The protocol number of ICMP for IPv6 is 58, not 1.

Patch Set 1 #

Patch Set 2 : diff -r 8b32d1715714 https://code.google.com/p/go #

Patch Set 3 : diff -r 8b32d1715714 https://code.google.com/p/go #

Patch Set 4 : diff -r 8b32d1715714 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/pkg/net/ipraw_test.go View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
mikio
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
11 years, 4 months ago (2012-11-07 10:15:36 UTC) #1
bradfitz
LGTM On Wed, Nov 7, 2012 at 11:15 AM, <mikioh.mikioh@gmail.com> wrote: > Reviewers: golang-dev_googlegroups.com, > ...
11 years, 4 months ago (2012-11-07 12:29:35 UTC) #2
mikio
11 years, 4 months ago (2012-11-07 12:55:38 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=e1d0c77a3cd5 ***

net: fix protocol number for IPv6 test

The protocol number of ICMP for IPv6 is 58, not 1.

R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/6810093
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b