Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(274)

Issue 6810090: code review 6810090: cmd/6g, cmd/8g: mark used registers in indirect addressing. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 8 months ago by remyoudompheng
Modified:
12 years, 8 months ago
Reviewers:
CC:
golang-dev, dave_cheney.net, rsc
Visibility:
Public.

Description

cmd/6g, cmd/8g: mark used registers in indirect addressing. Fixes issue 4094. Fixes issue 4353.

Patch Set 1 #

Patch Set 2 : diff -r 2b08c2106305 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 2b08c2106305 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r c37ad3c7cb80 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -0 lines) Patch
M src/cmd/6g/reg.c View 1 1 chunk +10 lines, -0 lines 0 comments Download
M src/cmd/8g/reg.c View 1 1 chunk +10 lines, -0 lines 0 comments Download
A test/fixedbugs/issue4353.go View 1 2 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 7
remyoudompheng
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
12 years, 8 months ago (2012-11-06 23:19:28 UTC) #1
remyoudompheng
The fixes issue 4094 is a bit hypothetical, it is a bit hard to actually ...
12 years, 8 months ago (2012-11-06 23:22:58 UTC) #2
dave_cheney.net
Is it possible to include the sample code from 4353 as in src/test ? On ...
12 years, 8 months ago (2012-11-06 23:26:14 UTC) #3
remyoudompheng
Hello golang-dev@googlegroups.com, dave@cheney.net (cc: golang-dev@googlegroups.com), Please take another look.
12 years, 8 months ago (2012-11-06 23:37:11 UTC) #4
dave_cheney.net
Thank you for adding the test. I wanted to make sure that the test passed ...
12 years, 8 months ago (2012-11-06 23:56:08 UTC) #5
rsc
LGTM Thanks very much for tracking that down.
12 years, 8 months ago (2012-11-07 14:22:34 UTC) #6
remyoudompheng
12 years, 8 months ago (2012-11-07 20:36:52 UTC) #7
*** Submitted as http://code.google.com/p/go/source/detail?r=aae11629f3e8 ***

cmd/6g, cmd/8g: mark used registers in indirect addressing.

Fixes issue 4094.
Fixes issue 4353.

R=golang-dev, dave, rsc
CC=golang-dev
http://codereview.appspot.com/6810090
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b