code review 6782075: sync/atomic: fix race instrumentation

sync/atomic: fix race instrumentation

[dvyukov, 2012-11-15 11:58:22]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://dvyukov%40google.com@code.google.com/p/go/

[iant2, 2012-11-15 17:22:21]

LGTM

On Thu, Nov 15, 2012 at 3:58 AM,  <dvyukov@google.com> wrote:
> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://dvyukov%40google.com@code.google.com/p/go/
>
>
> Description:
> sync/atomic: fix race instrumentation
>
> Please review this at http://codereview.appspot.com/6782075/
>
> Affected files:
>   M src/pkg/sync/atomic/race.go
>
>
> Index: src/pkg/sync/atomic/race.go
> ===================================================================
> --- a/src/pkg/sync/atomic/race.go
> +++ b/src/pkg/sync/atomic/race.go
> @@ -165,7 +165,7 @@
>
>  func LoadUintptr(addr *uintptr) (val uintptr) {
>         runtime.RaceSemacquire(&mtx)
> -       runtime.RaceRead(unsafe.Pointer(val))
> +       runtime.RaceRead(unsafe.Pointer(addr))
>         runtime.RaceAcquire(unsafe.Pointer(addr))
>         val = *addr
>         runtime.RaceSemrelease(&mtx)
> @@ -198,7 +198,7 @@
>
>  func StorePointer(addr *unsafe.Pointer, val unsafe.Pointer) {
>         runtime.RaceSemacquire(&mtx)
> -       runtime.RaceRead(unsafe.Pointer(val))
> +       runtime.RaceRead(unsafe.Pointer(addr))
>         *addr = val
>         runtime.RaceRelease(unsafe.Pointer(addr))
>         runtime.RaceSemrelease(&mtx)
> @@ -206,7 +206,7 @@
>
>  func StoreUintptr(addr *uintptr, val uintptr) {
>         runtime.RaceSemacquire(&mtx)
> -       runtime.RaceRead(unsafe.Pointer(val))
> +       runtime.RaceRead(unsafe.Pointer(addr))
>         *addr = val
>         runtime.RaceRelease(unsafe.Pointer(addr))
>         runtime.RaceSemrelease(&mtx)
>
>

[dvyukov, 2012-11-15 17:30:33]

*** Submitted as http://code.google.com/p/go/source/detail?r=c7a85aebdb9c ***

sync/atomic: fix race instrumentation

R=golang-dev, iant
CC=golang-dev
http://codereview.appspot.com/6782075