Issue 6775066: code review 6775066: misc/dashboard/builder: check http status before proces...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6775066: code review 6775066: misc/dashboard/builder: check http status before proces... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 8 months ago by dave

Modified:
12 years, 8 months ago

Reviewers:

CC:
adg, dsymonds, golang-dev

Visibility:
Public.

Description

misc/dashboard/builder: check http status before processing response Occasionally GAE will return a 500 error response, don't treat this as a valid JSON body.

Patch Set 1 #

Patch Set 2 : diff -r 8e87cb8dca7d https://code.google.com/p/go #

Patch Set 3 : diff -r 8e87cb8dca7d https://code.google.com/p/go #

Patch Set 4 : diff -r 3312fddeb739 https://code.google.com/p/go #

Created: 12 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	misc/dashboard/builder/http.go	View	1	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

dave_cheney.net

Hello adg@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

12 years, 8 months ago (2012-10-29 07:39:13 UTC) #1

dave_cheney.net

12 years, 8 months ago (2012-10-30 15:24:14 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=fa727f5a7154 ***

misc/dashboard/builder: check http status before processing response

Occasionally GAE will return a 500 error response, don't treat this as a valid
JSON body.

R=adg, dsymonds
CC=golang-dev
http://codereview.appspot.com/6775066

Expand All Messages | Collapse All Messages