code review 6745051: go.talks/present: display twitter names in @name format

go.talks/present: display twitter names in @name format

[adg, 2012-10-22 04:39:37]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go.talks

[adg, 2012-10-24 23:02:27]

Ping
On 22 Oct 2012 15:39, <adg@golang.org> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go.**talks <https://code.google.com/p/go.talks>
>
>
> Description:
> go.talks/present: display twitter names in @name format
>
> Please review this at
http://codereview.appspot.com/**6745051/<http://codereview.appspot.com/6745051/>
>
> Affected files:
>   M present/parse.go
>
>
> Index: present/parse.go
> ==============================**==============================**=======
> --- a/present/parse.go
> +++ b/present/parse.go
> @@ -349,6 +349,7 @@
>                         el = parseURL("http://twitter.com/" + text[1:])
>                         if l, ok := el.(Link); ok {
>                                 l.Args = []string{text}
> +                               el = l
>                         }
>                 case strings.Contains(text, ":"):
>                         el = parseURL(text)
>
>
>

[francesc, 2012-10-24 23:12:58]

https://codereview.appspot.com/6745051/diff/1/present/parse.go
File present/parse.go (right):

https://codereview.appspot.com/6745051/diff/1/present/parse.go#newcode370
present/parse.go:370: func parseURL(text string) Elem {
Shouldn't this method be part of link.go and return Link instead of Elem?

I think it's weird we're explicitly using an extension from the main code.

[r, 2012-10-24 23:41:57]

LGTM

[adg, 2012-10-25 00:00:34]

*** Submitted as
http://code.google.com/p/go/source/detail?r=51956b13eca8&repo=talks ***

go.talks/present: display twitter names in @name format

R=golang-dev, campoy, r
CC=golang-dev
http://codereview.appspot.com/6745051

[adg, 2012-10-25 00:02:09]

https://codereview.appspot.com/6745051/diff/1/present/parse.go
File present/parse.go (right):

https://codereview.appspot.com/6745051/diff/1/present/parse.go#newcode370
present/parse.go:370: func parseURL(text string) Elem {
On 2012/10/24 23:12:58, campoy1 wrote:
> Shouldn't this method be part of link.go and return Link instead of Elem?
> 
> I think it's weird we're explicitly using an extension from the main code.

Probably.