Issue 6744054: code review 6744054: fix clang warnings reported by Tuncer Ayaz

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6744054: code review 6744054: fix clang warnings reported by Tuncer Ayaz (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by rsc

Modified:
12 years, 2 months ago

Reviewers:

CC:
rsc

Visibility:
Public.

Description

fix clang warnings reported by Tuncer Ayaz

Patch Set 1 #

Patch Set 2 : diff -r d9cdc1795924 https://code.google.com/p/plan9port #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+586 lines, -588 lines)			Patch
M	lib/yaccpars	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/cmd/astro/jup.c	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/cmd/auth/dsasign.c	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/cmd/auth/factotum/chap.c	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/cmd/awk/run.c	View	1	3 chunks	+1 line, -4 lines	0 comments	Download
M	src/cmd/devdraw/x11-itrans.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/draw/tweak.c	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/cmd/ndb/dblookup.c	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/cmd/ndb/dns.c	View	1	1 chunk	+0 lines, -4 lines	0 comments	Download
M	src/cmd/postscript/tr2post/draw.c	View	1	5 chunks	+13 lines, -5 lines	0 comments	Download
M	src/cmd/rio/showevent/ShowEvent.c	View	1	4 chunks	+545 lines, -545 lines	0 comments	Download
M	src/cmd/sam/file.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/vac/vac.c	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/cmd/venti/srv/fixarenas.c	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/cmd/venti/srv/lumpcache.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/lib9/zoneinfo.c	View	1	2 chunks	+5 lines, -7 lines	0 comments	Download
M	src/lib9p/srv.c	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/libdiskfs/venti.c	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/libmach/symstabs.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/libsec/port/tlshand.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/libsunrpc/fmt.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/libsunrpc/mount3.c	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/libsunrpc/prog.c	View	1	4 chunks	+4 lines, -4 lines	0 comments	Download
M	src/libsunrpc/server.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

rsc

Hello rsc, I'd like you to review this change to https://code.google.com/p/plan9port

12 years, 2 months ago (2012-10-21 15:25:05 UTC) #1

rsc

12 years, 2 months ago (2012-10-21 15:25:15 UTC) #2

*** Submitted as http://code.google.com/p/plan9port/source/detail?r=33aade40e6ab
***

fix clang warnings reported by Tuncer Ayaz

R=rsc
http://codereview.appspot.com/6744054

Expand All Messages | Collapse All Messages