Issue 6739048: code review 6739048: cmd/gc: Friendlier errors on oversized arrays.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6739048: code review 6739048: cmd/gc: Friendlier errors on oversized arrays. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 9 months ago by DMorsing

Modified:
12 years, 9 months ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

cmd/gc: Friendlier errors on oversized arrays. Someone new to the language may not know the connection between ints and arrays, which was the only thing that the previous error told you anything about. Fixes issue 4256.

Patch Set 1 #

Patch Set 2 : diff -r 46d3a6e21a75 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 46d3a6e21a75 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 5ff25ab9358f https://code.google.com/p/go/ #

Created: 12 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -13 lines)			Patch
M	src/cmd/gc/const.c	View	1	3 chunks	+31 lines, -9 lines	0 comments	Download
M	src/cmd/gc/go.h	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	src/cmd/gc/typecheck.c	View	1	1 chunk	+4 lines, -2 lines	0 comments	Download
M	test/fixedbugs/bug255.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

DMorsing

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

12 years, 9 months ago (2012-10-21 09:32:34 UTC) #1

DMorsing

12 years, 9 months ago (2012-10-21 17:23:00 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=c7597460474e ***

cmd/gc: Friendlier errors on oversized arrays.

Someone new to the language may not know the connection between ints and arrays,
which was the only thing that the previous error told you anything about.

Fixes issue 4256.

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/6739048

Expand All Messages | Collapse All Messages