Issue 6713043: code review 6713043: gophertool: fix links

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6713043: code review 6713043: gophertool: fix links (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 6 months ago by minux1

Modified:
12 years, 6 months ago

Reviewers:

CC:
bradfitz, golang-dev

Visibility:
Public.

Patch Set 2 : diff -r 49a2b4f39297 https://code.google.com/p/go/ #

Total comments: 1

Patch Set 3 : diff -r 46d3a6e21a75 https://code.google.com/p/go/ #

Created: 12 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -9 lines)			Patch
	M	misc/chrome/gophertool/popup.html	View	1	1 chunk	+5 lines, -5 lines	0 comments	Download
	M	misc/chrome/gophertool/popup.js	View	1	2 chunks	+12 lines, -4 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

minux1

Hello bradfitz@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

12 years, 6 months ago (2012-10-16 07:46:23 UTC) #1

bradfitz

LGTM https://codereview.appspot.com/6713043/diff/2001/misc/chrome/gophertool/popup.js File misc/chrome/gophertool/popup.js (right): https://codereview.appspot.com/6713043/diff/2001/misc/chrome/gophertool/popup.js#newcode11 misc/chrome/gophertool/popup.js:11: openURL(this.getAttribute("url")); oh, JavaScript scoping. I was going to ...

12 years, 6 months ago (2012-10-20 16:49:46 UTC) #3

minux1

12 years, 6 months ago (2012-10-21 17:05:36 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=ae3d5ab86c84 ***

gophertool: fix links

R=bradfitz
CC=golang-dev
http://codereview.appspot.com/6713043

Expand All Messages | Collapse All Messages