Issue 6643062: code review 6643062: godoc: fix site for large displays

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6643062: code review 6643062: godoc: fix site for large displays (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 5 months ago by adg

Modified:
12 years, 5 months ago

Reviewers:

CC:
golang-dev, skybrian1

Visibility:
Public.

Patch Set 2 : diff -r c3570e8ed478 https://code.google.com/p/go #

Patch Set 3 : diff -r cd34abb3699f https://code.google.com/p/go #

Created: 12 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	doc/style.css	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

adg

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

12 years, 5 months ago (2012-10-10 21:57:47 UTC) #1

skybrian1

https://codereview.appspot.com/6643062/diff/1/doc/style.css File doc/style.css (right): https://codereview.appspot.com/6643062/diff/1/doc/style.css#newcode153 doc/style.css:153: max-width: 1200px; Is this necessary? I'm wondering if we ...

12 years, 5 months ago (2012-10-10 22:09:17 UTC) #2

adg

12 years, 5 months ago (2012-10-10 22:11:55 UTC) #3

adg

Hello golang-dev@googlegroups.com, skybrian@google.com (cc: golang-dev@googlegroups.com), Please take another look.

12 years, 5 months ago (2012-10-10 22:12:11 UTC) #4

skybrian1

Seems fine. However, if you want me to test this, I'll have to do it ...

12 years, 5 months ago (2012-10-10 22:14:07 UTC) #5

adg

*** Submitted as http://code.google.com/p/go/source/detail?r=75c634bee1e5 *** godoc: fix site for large displays R=golang-dev, skybrian CC=golang-dev http://codereview.appspot.com/6643062

12 years, 5 months ago (2012-10-10 22:18:47 UTC) #6

adg

12 years, 5 months ago (2012-10-10 22:18:49 UTC) #7

On 11 October 2012 09:14,  <skybrian@google.com> wrote:
> Seems fine. However, if you want me to test this, I'll have to do it
> later.

No, that's ok. I have tested it.

Expand All Messages | Collapse All Messages