Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(320)

Issue 6643046: code review 6643046: runtime: sizeclass in MSpan should be int32. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 10 months ago by diogin
Modified:
12 years, 9 months ago
Reviewers:
CC:
golang-dev, minux1, dave_cheney.net, rsc
Visibility:
Public.

Description

runtime: sizeclass in MSpan should be int32.

Patch Set 1 #

Patch Set 2 : diff -r 2c2052f38c3c https://code.google.com/p/go/ #

Patch Set 3 : diff -r 767901053800 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/pkg/runtime/malloc.h View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9
diogin
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com, rsc@golang.org), I'd like you to review this change to https://code.google.com/p/go/
12 years, 10 months ago (2012-10-11 02:22:32 UTC) #1
minux1
any explanations?
12 years, 10 months ago (2012-10-11 05:21:21 UTC) #2
diogin
All sizeclass in runrime are int32. I suspect this uint32 sizeclass is a neglect. 在 ...
12 years, 10 months ago (2012-10-11 06:30:48 UTC) #3
dave_cheney.net
On the contrary, I think this is the only one that is correct. How can ...
12 years, 10 months ago (2012-10-11 07:23:47 UTC) #4
diogin
"sizeclass" is different with "size". It is the class of size, not the size itself. ...
12 years, 10 months ago (2012-10-11 07:44:44 UTC) #5
minux1
LGTM, will wait for others' opinion before submit. Have you signed the CLA as described ...
12 years, 10 months ago (2012-10-11 16:36:01 UTC) #6
diogin
Just signed it, the page said it would process my submission shortly, not sure whether ...
12 years, 10 months ago (2012-10-12 02:24:50 UTC) #7
rsc
It's hard to get excited about this but okay.
12 years, 10 months ago (2012-10-16 17:17:19 UTC) #8
rsc
12 years, 9 months ago (2012-10-22 00:32:47 UTC) #9
*** Submitted as http://code.google.com/p/go/source/detail?r=681b2f0da7a8 ***

runtime: sizeclass in MSpan should be int32.

R=golang-dev, minux.ma, dave, rsc
CC=golang-dev
http://codereview.appspot.com/6643046

Committer: Russ Cox <rsc@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b