Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com, rsc@golang.org), I'd like you to review this change to https://code.google.com/p/go/
12 years, 10 months ago
(2012-10-11 02:22:32 UTC)
#1
All sizeclass in runrime are int32. I suspect this uint32 sizeclass is a neglect. 在 ...
12 years, 10 months ago
(2012-10-11 06:30:48 UTC)
#3
All sizeclass in runrime are int32. I suspect this uint32 sizeclass is a
neglect.
在 2012-10-11 PM1:21,"minux" <minux.ma@gmail.com>写道:
> any explanations?
>
On the contrary, I think this is the only one that is correct. How can ...
12 years, 10 months ago
(2012-10-11 07:23:47 UTC)
#4
On the contrary, I think this is the only one that is correct. How can you have
something that is -5 bytes big?
On 11/ can10/2012, at 17:30, Jingcheng Zhang <diogin@gmail.com> wrote:
> All sizeclass in runrime are int32. I suspect this uint32 sizeclass is a
neglect.
>
> 在 2012-10-11 PM1:21,"minux" <minux.ma@gmail.com>写道:
>> any explanations?
"sizeclass" is different with "size". It is the class of size, not the size itself. ...
12 years, 10 months ago
(2012-10-11 07:44:44 UTC)
#5
"sizeclass" is different with "size". It is the class of size, not the size
itself. There are currently 61 sizeclasses (through an enum value
NumSizeClasses) defined for allocation.
On 2012/10/11 07:23:47, dfc wrote:
> On the contrary, I think this is the only one that is correct. How can you
have
> something that is -5 bytes big?
>
> On 11/ can10/2012, at 17:30, Jingcheng Zhang <mailto:diogin@gmail.com> wrote:
>
> > All sizeclass in runrime are int32. I suspect this uint32 sizeclass is a
> neglect.
> >
> > 在 2012-10-11 PM1:21,"minux" <minux.ma@gmail.com>写道:
> >> any explanations?
Just signed it, the page said it would process my submission shortly, not sure whether ...
12 years, 10 months ago
(2012-10-12 02:24:50 UTC)
#7
Just signed it, the page said it would process my submission shortly, not sure
whether it is completed now.
On 2012/10/11 16:36:01, minux wrote:
> LGTM, will wait for others' opinion before submit.
>
> Have you signed the CLA as described at
> http://golang.org/doc/contribute.html#copyright?
*** Submitted as http://code.google.com/p/go/source/detail?r=681b2f0da7a8 *** runtime: sizeclass in MSpan should be int32. R=golang-dev, minux.ma, dave, ...
12 years, 9 months ago
(2012-10-22 00:32:47 UTC)
#9
Issue 6643046: code review 6643046: runtime: sizeclass in MSpan should be int32.
(Closed)
Created 12 years, 10 months ago by diogin
Modified 12 years, 9 months ago
Reviewers:
Base URL:
Comments: 0