code review 6643043: reflect: make Index and Slice accept strings

reflect: make Index and Slice accept strings

Fixes issue 3284.

[eds, 2012-10-08 23:01:42]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[r, 2012-10-09 05:19:42]

i could have sworn i already did this, but obviously not

http://codereview.appspot.com/6643043/diff/4001/src/pkg/reflect/all_test.go
File src/pkg/reflect/all_test.go (right):

http://codereview.appspot.com/6643043/diff/4001/src/pkg/reflect/all_test.go#n...
src/pkg/reflect/all_test.go:2045: 
d

http://codereview.appspot.com/6643043/diff/4001/src/pkg/reflect/all_test.go#n...
src/pkg/reflect/all_test.go:2051: 
d

http://codereview.appspot.com/6643043/diff/4001/src/pkg/reflect/all_test.go#n...
src/pkg/reflect/all_test.go:2083: 
d

http://codereview.appspot.com/6643043/diff/4001/src/pkg/reflect/value.go
File src/pkg/reflect/value.go (right):

http://codereview.appspot.com/6643043/diff/4001/src/pkg/reflect/value.go#newc...
src/pkg/reflect/value.go:813: var uint8Type = TypeOf(byte(0)).(*commonType)
s/byte/uint8/

[eds, 2012-10-09 05:56:23]

Hello golang-dev@googlegroups.com, r@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[r, 2012-10-09 06:30:13]

LGTM
leaving for rsc

http://codereview.appspot.com/6643043/diff/9001/src/pkg/reflect/value.go
File src/pkg/reflect/value.go (right):

http://codereview.appspot.com/6643043/diff/9001/src/pkg/reflect/value.go#newc...
src/pkg/reflect/value.go:1480: panic("reflect.Value.Slice: string index out of
bounds")
maybe
string slice index out of bounds

[rsc, 2012-10-09 17:02:01]

LGTM

Please fix the error and re-hg mail

https://codereview.appspot.com/6643043/diff/9001/src/pkg/reflect/value.go
File src/pkg/reflect/value.go (right):

https://codereview.appspot.com/6643043/diff/9001/src/pkg/reflect/value.go#new...
src/pkg/reflect/value.go:1480: panic("reflect.Value.Slice: string index out of
bounds")
On 2012/10/09 06:30:13, r wrote:
> maybe
> string slice index out of bounds

sgtm

[eds, 2012-10-09 18:22:31]

Hello golang-dev@googlegroups.com, r@golang.org, rsc@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[eds, 2012-10-12 20:13:04]

Ping

[r, 2012-10-14 21:34:37]

LGTM
leaving for rsc

[rsc, 2012-10-21 21:02:20]

*** Submitted as http://code.google.com/p/go/source/detail?r=d264297d1d8f ***

reflect: make Index and Slice accept strings

Fixes issue 3284.

R=golang-dev, r, rsc
CC=golang-dev
http://codereview.appspot.com/6643043

Committer: Russ Cox <rsc@golang.org>