Issue 6641052: code review 6641052: encoding/xml: Allow arbitrary XML names as entity refer...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6641052: code review 6641052: encoding/xml: Allow arbitrary XML names as entity refer... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by pat42smith

Modified:
11 years, 6 months ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

encoding/xml: Allow arbitrary XML names as entity references. Previously, multi-byte characters were not allowed. Also certain single-byte characters, such as '-', were disallowed. Fixes issue 3813.

Patch Set 1 #

Patch Set 2 : diff -r 3787ef7b4700 https://code.google.com/p/go #

Patch Set 3 : diff -r caf30a0fbd77 https://code.google.com/p/go #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+156 lines, -91 lines)			Patch
	M	src/pkg/encoding/xml/xml.go	View	1	5 chunks	+121 lines, -91 lines	0 comments	Download
	M	src/pkg/encoding/xml/xml_test.go	View	1	8 chunks	+35 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

pat42smith

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

11 years, 6 months ago (2012-10-11 19:21:27 UTC) #1

rsc

11 years, 6 months ago (2012-10-22 00:33:28 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=50ab184b075b ***

encoding/xml: expand allowed entity names

Previously, multi-byte characters were not allowed. Also certain single-byte
characters, such as '-', were disallowed.
Fixes issue 3813.

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/6641052

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages